Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump Gradle to version 8.8 #13753

Closed
Tracked by #11230
rbair23 opened this issue Jun 7, 2024 · 4 comments
Closed
Tracked by #11230

Chore: Bump Gradle to version 8.8 #13753

rbair23 opened this issue Jun 7, 2024 · 4 comments
Assignees

Comments

@rbair23
Copy link
Member

rbair23 commented Jun 7, 2024

Version 8.6 of Gradle prints a warning with the latest 21.0.3 build of Java. We should upgrade to Gradle 8.8.

@rbair23
Copy link
Member Author

rbair23 commented Jun 7, 2024

Ah, I'm not sure this actually removes the warning.

@jsync-swirlds
Copy link
Member

The warning about 21.0.1 is because the build specifies that java version. Not sure if it's possible, but specifying only the major version (21) would avoid warnings for every bugfix update.

@jjohannes
Copy link
Collaborator

The issue should be: Update JDK to 21.0.3

We pin down the exact JDK version for reproducible builds. Gradle does not yet support providing an exact version automatically (gradle/gradle#16628). Therefore, everyone running the build (CI or user) need to make sure the version is installed and Gradle starts with it (documentation will also explain that once #12813 is merged).

Right now the version is defined in multiple places in GH Actions and in one place in Gradle. This could be simplified by defining the version in a separate file and using it in GH Actions via the java-version-file configuration of the action/setup-java. Then there would only be one place. But that's a GH Actions topic. We could create a separate issue for that (cc @rbarkerSL)

Anyway, I created two PRs for both updates (Java and Gradle). This shows the places that need to touched in this repo. I don't know if the JDK version is also defined somewhere else as well in other CI/CD automation outside this repo:

@jjohannes
Copy link
Collaborator

Gradle has been upgraded to 8.8 by #13757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants