-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): fail if Gradle is started with Java 20 or older #12780
Conversation
Signed-off-by: Anthony Petrov <[email protected]>
Signed-off-by: Anthony Petrov <[email protected]>
Signed-off-by: Anthony Petrov <[email protected]>
Signed-off-by: Anthony Petrov <[email protected]>
Node: HAPI Test (Restart) Results2 tests 2 ✅ 5m 55s ⏱️ Results for commit c7e950d. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results1 tests 1 ✅ 23s ⏱️ For more details on these parsing errors, see this check. Results for commit c7e950d. |
Node: HAPI Test (Token) Results212 tests 212 ✅ 18m 49s ⏱️ Results for commit c7e950d. |
Node: HAPI Test (Crypto) Results317 tests 317 ✅ 36m 41s ⏱️ Results for commit c7e950d. |
Node: HAPI Test (Misc) Results435 tests 425 ✅ 36m 35s ⏱️ Results for commit c7e950d. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 10s ⏱️ Results for commit c7e950d. |
Node: HAPI Test (Smart Contract) Results556 tests 556 ✅ 1h 8m 2s ⏱️ Results for commit c7e950d. |
Node: Unit Test Results 2 281 files ±0 2 281 suites ±0 3h 29m 30s ⏱️ + 1h 26m 10s Results for commit c7e950d. ± Comparison against base commit 2dde6dc. This pull request removes 3996 and adds 3761 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Created #12798 and autonomousapps/dependency-analysis-gradle-plugin#1167 for further work in this area. For now, I think this is a good step forward. From my side, this can be merged. |
Description:
Require Gradle to be started using Java 21+. Fail the build if the default JDK (in JAVA_HOME/PATH) points to an older version of Java.
Related issue(s):
Fixes #12779
Notes for reviewer:
For testing purposes, when JAVA_HOME points to Java 17, the build fails as:
Checklist