-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement hss sign schedule function #16789
Conversation
Signed-off-by: Luke Lee <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, ty @lukelee-sl !
Left a few suggestions for improvement but all up to you
...-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/TransactionProcessor.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ContractsConfig.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Luke Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…into 16700-implement-sign-schedule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will come back for tests (bdd) later. Some questions for now.
...pp/src/test/java/com/hedera/node/app/workflows/handle/dispatch/ChildDispatchFactoryTest.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/TransactionProcessor.java
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/TransactionProcessor.java
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/TransactionProcessor.java
Show resolved
Hide resolved
.../java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/hss/HssCallAttempt.java
Outdated
Show resolved
Hide resolved
.../node/app/service/contract/impl/exec/systemcontracts/hss/DispatchForResponseCodeHssCall.java
Show resolved
Hide resolved
.../node/app/service/contract/impl/exec/systemcontracts/hss/DispatchForResponseCodeHssCall.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/state/DispatchingEvmFrameState.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Luke Lee <[email protected]>
Signed-off-by: Luke Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (though there's still a question about simple keys remaining for completeness)
...pp/src/test/java/com/hedera/node/app/workflows/handle/dispatch/ChildDispatchFactoryTest.java
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/TransactionProcessor.java
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/state/DispatchingEvmFrameState.java
Show resolved
Hide resolved
…atch Signed-off-by: Luke Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with new solution for 'forwarding" simple keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @lukelee-sl !
Signed-off-by: Luke Lee <[email protected]>
Description:
Implements the
signSchedule
proxy contract function and theauthorizeSchedule
function for the Schedule system contract.Related issue(s):
Fixes #16700
Notes for reviewer:
A future pr will add additional BDD and unit test.
Checklist