Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC]: add usage and coverage for Frictionless Airdrop (HIP-904) #1012

Open
10 of 12 tasks
quiet-node opened this issue Nov 13, 2024 · 5 comments
Open
10 of 12 tasks

[EPIC]: add usage and coverage for Frictionless Airdrop (HIP-904) #1012

quiet-node opened this issue Nov 13, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request Epic Collections of tasks
Milestone

Comments

@quiet-node
Copy link
Member

quiet-node commented Nov 13, 2024

Problem

HIP-904, Frictionless Airdrop, has been fully implemented in [email protected] but currently lacks Solidity usage and test coverage.

Solution

Implement Solidity usage and add test coverage to verify that all features function as expected.

HIP 904 System Contract Function Verification Tasks

Preview Give feedback
  1. internal
    nadezhdapopovaa
  2. internal
    simzzz
  3. enhancement
    Nana-EC
  4. enhancement
    Nana-EC
  5. enhancement
    simzzz
  6. enhancement
    simzzz
  7. enhancement
    simzzz
  8. enhancement
    simzzz
  9. enhancement
    simzzz
  10. enhancement
    simzzz
  11. enhancement
    simzzz
  12. enhancement
    simzzz

Note: As of 0.56 the target of an airdrop should be an EOA. Also MN does not yet support this logic

Alternatives

No response

@quiet-node quiet-node added the enhancement New feature or request label Nov 13, 2024
@quiet-node quiet-node added this to the 0.11.0 milestone Nov 13, 2024
@quiet-node quiet-node self-assigned this Nov 13, 2024
@quiet-node quiet-node moved this from Backlog to Tasks In Progress in Smart Contract Sprint Board Nov 13, 2024
@Nana-EC Nana-EC moved this from Tasks In Progress to Sprint Backlog in Smart Contract Sprint Board Nov 13, 2024
@Nana-EC Nana-EC added the Epic Collections of tasks label Nov 13, 2024
@Nana-EC Nana-EC moved this from Sprint Backlog to Epics In Progress in Smart Contract Sprint Board Nov 23, 2024
@Nana-EC
Copy link
Collaborator

Nana-EC commented Nov 23, 2024

@quiet-node or @victor-yanev let's clean up #1011 and get it in now.
May also need to do a positive handoff to another team member to handle this depending on how sprint planning goes.
Whoever picks this up should sync w @stoyanov-st for context on latest 0.57 functionality as there may be new gaps.

@Nana-EC
Copy link
Collaborator

Nana-EC commented Nov 25, 2024

@quiet-node added that we should upgrade the local node version of the repo to support this and ensure the feature flag is turned on.

@quiet-node quiet-node changed the title feat: add usage and coverage for Frictionless Airdrop (HIP-904) [EPIC]: add usage and coverage for Frictionless Airdrop (HIP-904) Nov 26, 2024
@quiet-node
Copy link
Member Author

quiet-node commented Nov 26, 2024

Refer to PR #1011 for a valuable reference.

@simzzz
Copy link
Contributor

simzzz commented Dec 10, 2024

I'm picking this up, you can assign me

@quiet-node
Copy link
Member Author

This design document serves as an additional valuable reference:https://github.com/hashgraph/hedera-services/blob/v0.56.1/hedera-node/docs/design/services/smart-contract-service/frictionless-airdrops-system-contracts.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic Collections of tasks
Projects
Status: Epics In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants