Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERC Registry EPIC] Phase 2: Integrate validation through the contract call API and address edge cases to enhance accuracy. #1067

Closed
5 tasks done
Tracked by #1028
quiet-node opened this issue Dec 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request Epic Collections of tasks
Milestone

Comments

@quiet-node
Copy link
Member

quiet-node commented Dec 9, 2024

Problem

After Phase 1, the ERC indexing tool can now detect ERC contracts and categorize them into ERC-20 and ERC-721. However, the categorized contracts only include the contract ID and EVM address, lacking other essential information such as name, symbol, and decimals.

Solution

Implement a new mechanism to make calls to the mirror node to retrieve the necessary information.

A better and improved schema for an ERC20 should include detailed token information

{
    "address": "0x....",  // Address of the ERC20 contract/token
    "contractId": "0.0.x",  // contract id of the ERC20 contract/token
    "name": "...",
    "symbol": "...",
    "decimals": x,
    "totalSupply": "..."
  }

A better and improved schema for an ERC721 should include detailed token information

{
    "address": "0x....",  // Address of the ERC20 contract/token
    "contractId": "0.0.x",  // contract id of the ERC20 contract/token
    "name": "...",
    "symbol": "...",
  }

Alternatives

No response

@quiet-node quiet-node self-assigned this Dec 9, 2024
@quiet-node quiet-node added enhancement New feature or request Epic Collections of tasks labels Dec 9, 2024
@quiet-node quiet-node moved this from Backlog to Epics In Progress in Smart Contract Sprint Board Dec 9, 2024
@quiet-node quiet-node modified the milestones: 0.11.0, 0.12.0 Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Epics In Progress to Done in Smart Contract Sprint Board Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic Collections of tasks
Projects
Status: Done
Development

No branches or pull requests

1 participant