Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repetitive deploy functions from hedera-token-service/utils.js and use the generic deployContract() #1199

Open
simzzz opened this issue Jan 21, 2025 · 0 comments
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.

Comments

@simzzz
Copy link
Contributor

simzzz commented Jan 21, 2025

Problem

Currently in hedera-token-service/utils.js there are repeated functions that deploy a contract, but all the logic is the same. There also exists a generic deployContract() function which accepts the contract as a parameter. This adds unnecessary code repetition and makes the code harder to maintain.

Solution

  • Remove all functions that deploy a contract in hedera-token-service/utils.js except the generic one deployContract
  • Replace their usage across the codebase with deployContract and pass the contract as a parameter instead

Alternatives

No response

@simzzz simzzz added the enhancement New feature or request label Jan 21, 2025
@quiet-node quiet-node added internal For changes that affect the project's internal workings but not its outward-facing functionality. and removed enhancement New feature or request labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants