feat: milestone 1 - replay 30% of all sepolia transactions (#1201) #1236

arianejasuwienas · 2025-02-06T08:58:39Z

Description:
This Epic covers the effort to replay 30% of all Sepolia transactions and includes tasks related to code cleanup and repository migration. The goal is to reach 30% transaction replay by the end of January. Successful completion of this milestone will require the resolution of several key issues within the forked repository.

This PR includes:

Logging improvement Ariane-Labs/hedera-smart-contracts
Rewrite transaction checker from GO to TypeScript(node) Ariane-Labs/hedera-smart-contracts
Refactor how transaction checker handles logs Ariane-Labs/hedera-smart-contracts
Review documentation Ariane-Labs/hedera-smart-contracts

Related issue:

Fixes #1201

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Michał Walczak <[email protected]>

…onfiguration options (#2) Signed-off-by: Michał Walczak <[email protected]>

…rror messages (#2) Signed-off-by: Michał Walczak <[email protected]>

Signed-off-by: Michał Walczak <[email protected]>

github-actions · 2025-02-06T09:14:27Z

Test Results

17 files ± 0 103 suites ±0 24m 39s ⏱️ + 8m 15s
370 tests +33 348 ✅ +35 19 💤 +6 3 ❌ - 8
467 runs ± 0 443 ✅ + 1 21 💤 +7 3 ❌ - 8

For more details on these failures, see this check.

Results for commit 206bba6. ± Comparison against base commit 3aa1542.

This pull request removes 5 and adds 38 tests. Note that renamed tests count towards both.

"before all" hook for "should cancel a pending airdrop for a fungible token (FT)" ‑ HIP904 IHRC904Facade ContractTest Suite "before all" hook for "should cancel a pending airdrop for a fungible token (FT)"
"before all" hook for "should cancel a single pending fungible token airdrop" ‑ HIP904 CancelAirdropContract Test Suite "before all" hook for "should cancel a single pending fungible token airdrop"
"before all" hook for "should claim a single pending fungible token airdrop" ‑ HIP904 ClaimAirdropContract Test Suite "before all" hook for "should claim a single pending fungible token airdrop"
"before all" hook for "should reject tokens for a single account" ‑ HIP904 TokenRejectContract Test Suite "before all" hook for "should reject tokens for a single account"
"before each" hook for "Should check if an address is another address's operator" ‑ @OZERC1155Token Test Suite "before each" hook for "Should check if an address is another address's operator"

Should NOT allow a non-operator to transfer tokens to another account ‑ @OZERC1155Token Test Suite Should NOT allow a non-operator to transfer tokens to another account
Should NOT burn insufficient amount of token ‑ @OZERC1155Token Test Suite Should NOT burn insufficient amount of token
Should NOT transfer the ownership to another account if the caller is not owner ‑ @OZERC1155Token Test Suite Should NOT transfer the ownership to another account if the caller is not owner
Should allow an operator to transfer a token to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer a token to another account
Should allow an operator to transfer tokens in batch to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer tokens in batch to another account
Should burn token in batch ‑ @OZERC1155Token Test Suite Should burn token in batch
Should burn token ‑ @OZERC1155Token Test Suite Should burn token
Should check if an address is another address's operator ‑ @OZERC1155Token Test Suite Should check if an address is another address's operator
Should retrieve the token uri of a tokenID ‑ @OZERC1155Token Test Suite Should retrieve the token uri of a tokenID
Should set a new token URI ‑ @OZERC1155Token Test Suite Should set a new token URI
…

♻️ This comment has been updated with latest results.

…-from-go-to-ts feat: transaction checker app (#2)

Signed-off-by: mp-arianelabs <[email protected]>

…tory chore: move all of the shadowing services to scripts folder (#7)

Signed-off-by: mp-arianelabs <[email protected]>

docs: review documentation (#5)

Signed-off-by: mp-arianelabs <[email protected]>

…ecker-handles-logs feat: add new csv loggers for each file, new options to csv logger (#3)

Signed-off-by: mp-arianelabs <[email protected]>

…eadmes chore: update folder naming and READMEs (#15)

Nana-EC

Got like a third of the way through. See initial set of comments that may apply to many other files

Nana-EC · 2025-02-14T21:30:54Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/README.md

+### Description
+
+Goal of the Hedera shadowing process is to research the Hedera EVM and Ethereum EVM equivalence.
+This is achieved by re-executing all Ethereum transaction on by one on local Hedera network. Each transaction is verified by states match.


Suggested change

This is achieved by re-executing all Ethereum transaction on by one on local Hedera network. Each transaction is verified by states match.

This is achieved by re-executing all Ethereum transaction one by one on a local Hedera network. Each transaction is verified by states match.

Nana-EC · 2025-02-14T21:31:59Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/README.md

+### Description
+
+Goal of the Hedera shadowing process is to research the Hedera EVM and Ethereum EVM equivalence.
+This is achieved by re-executing all Ethereum transaction on by one on local Hedera network. Each transaction is verified by states match.


Can you clarify the states match.
It may not be clear to a reader if you are comparing balance or storage or both?

Nana-EC · 2025-02-14T21:33:58Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/README.md

+This is an outline of what the script does:
+
+1. First step populates the empty Hedera local node with Sepolia genesis block accounts and assigns them proper balances by transferring funds from the treasury account in Hedera (Account Id 0.0.2). The genesis state is provided from [genesis_block_transactions.json](./src/genesis_block_transactions.json).
+2. The last block from Sepolia is read, we iterate through all the block in a loop, starting from genesis block.


The last block from Sepolia is read make the rest of the sentence unclear

Nana-EC · 2025-02-14T21:38:58Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/README.md

+
+1. First step populates the empty Hedera local node with Sepolia genesis block accounts and assigns them proper balances by transferring funds from the treasury account in Hedera (Account Id 0.0.2). The genesis state is provided from [genesis_block_transactions.json](./src/genesis_block_transactions.json).
+2. The last block from Sepolia is read, we iterate through all the block in a loop, starting from genesis block.
+3. For each block its miners and uncles are read. The reward for block calculated is sent to an account in Hedera using the `TransferTransaction` method from the Hashgraph SDK.


Maybe add something like this

Suggested change

3. For each block its miners and uncles are read. The reward for block calculated is sent to an account in Hedera using the `TransferTransaction` method from the Hashgraph SDK.

3. For each block its miners and uncles are read. The reward for block calculated is sent to an account in Hedera using the `TransferTransaction` method from the Hashgraph SDK. This is necessary to ensure node account balances are accurate as Ethereum and Hedera rewards nodes in different ways.

Nana-EC · 2025-02-15T03:06:52Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/contracts/storage/README.md

@@ -0,0 +1,66 @@
+## Foundry


This is a cop of the foundry README.
This should be updated with relevant content

The content should include explaining what scripts/ethereum-shadow-network/hedera-ethereum-shadowing/contracts/storage/broadcast/Storage.s.sol/296/run-1726229520.json and others do

Nana-EC · 2025-02-15T03:08:56Z

...pts/ethereum-shadow-network/hedera-ethereum-shadowing/contracts/storage/script/Storage.s.sol

@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: UNLICENSED


License headers should be Apache i believe. Confirm with the other contract files in this repo.

Nana-EC · 2025-02-15T03:10:09Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/package.json

@@ -0,0 +1,50 @@
+{
+  "name": "hedera-eth-shadowing",


Fully qualify name with github org

Nana-EC · 2025-02-15T03:10:28Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/src/api/config.ts

@@ -0,0 +1,22 @@
+import axios from 'axios';


missing license on all ts files

Nana-EC · 2025-02-15T03:11:32Z

...ethereum-shadow-network/hedera-ethereum-shadowing/src/api/erigon/get-block-by-hash-erigon.ts

@@ -0,0 +1,20 @@
+import { axiosInstanceErigon } from '@/api/config';


This file seems like a subset of the next file. Are both needed?

Nana-EC · 2025-02-15T03:12:12Z

scripts/ethereum-shadow-network/hedera-ethereum-shadowing/src/apps/issues/index.ts

+client.setOperator(accountId, OPERATOR_PRIVATE || '');
+
+(() => {
+	// No gass error issue


Why the commented out code?
If it's not needed then remove it

mwb-al added 5 commits January 24, 2025 12:33

feat: transaction checker app (#2)

16a2e2c

Signed-off-by: Michał Walczak <[email protected]>

chore: simplified the tsconfig.json by removing all commented-out c…

414c48c

…onfiguration options (#2) Signed-off-by: Michał Walczak <[email protected]>

chore: replaced console.log with .error in to appropriately log e…

74c890f

…rror messages (#2) Signed-off-by: Michał Walczak <[email protected]>

chore: update logging config and README for consistency and clarity (#2)

a155a8b

Signed-off-by: Michał Walczak <[email protected]>

chore: add TODO for handling payload loss in Mirror Node errors (#2)

ae80e71

Signed-off-by: Michał Walczak <[email protected]>

arianejasuwienas added the Epic Collections of tasks label Feb 6, 2025

arianejasuwienas added this to the 0.12.0 milestone Feb 6, 2025

arianejasuwienas self-assigned this Feb 6, 2025

arianejasuwienas requested review from a team as code owners February 6, 2025 08:58

arianejasuwienas requested review from andrewb1269hg, jeromy-cannon and bubo February 6, 2025 08:58

arianejasuwienas changed the title ~~#1201 - Milestone 1 - Replay 30% of All Sepolia Transactions~~ Milestone 1 - Replay 30% of All Sepolia Transactions (#1201) Feb 6, 2025

arianejasuwienas changed the title ~~Milestone 1 - Replay 30% of All Sepolia Transactions (#1201)~~ feat: milestone 1 - replay 30% of all sepolia transactions (#1201) Feb 6, 2025

arianejasuwienas marked this pull request as draft February 6, 2025 09:05

arianejasuwienas force-pushed the 1201-shadowing-milestone-1 branch from a3f9bf0 to 21bd47d Compare February 11, 2025 11:06

mp-arianelabs added 10 commits February 11, 2025 13:25

Merge pull request #28 from Ariane-Labs/2-rewrite-transaction-checker…

25008ae

…-from-go-to-ts feat: transaction checker app (#2)

chore: move all of the shadowing services to scripts folder (#7)

0eee25f

Signed-off-by: mp-arianelabs <[email protected]>

Merge pull request #29 from Ariane-Labs/7-transfer-code-to-new-reposi…

6ac243d

…tory chore: move all of the shadowing services to scripts folder (#7)

docs: update readmes, add dep diagram (#5)

644f80c

Signed-off-by: mp-arianelabs <[email protected]>

Merge pull request #30 from Ariane-Labs/5-review-documentation

6b33de1

docs: review documentation (#5)

feat: add new csv loggers for each file, new options to csv logger (#3)

782934e

Signed-off-by: mp-arianelabs <[email protected]>

feat: implement usage of new logger in comparsion, remove old file (#3)

cb4a186

Signed-off-by: mp-arianelabs <[email protected]>

Merge pull request #27 from Ariane-Labs/3-refactor-how-transaction-ch…

79ac2d6

…ecker-handles-logs feat: add new csv loggers for each file, new options to csv logger (#3)

chore: update folder naming (#15)

8395828

Signed-off-by: mp-arianelabs <[email protected]>

docs: update READMEs (#15)

6bd6c2b

Signed-off-by: mp-arianelabs <[email protected]>

mp-arianelabs added 2 commits February 11, 2025 13:37

chore: remove usage of pnpm (#15)

a1b7cd1

Signed-off-by: mp-arianelabs <[email protected]>

Merge pull request #31 from Ariane-Labs/15-update-folder-naming-and-r…

206bba6

…eadmes chore: update folder naming and READMEs (#15)

arianejasuwienas force-pushed the 1201-shadowing-milestone-1 branch from 21bd47d to 206bba6 Compare February 11, 2025 13:00

arianejasuwienas marked this pull request as ready for review February 12, 2025 08:07

Nana-EC reviewed Feb 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: milestone 1 - replay 30% of all sepolia transactions (#1201) #1236

feat: milestone 1 - replay 30% of all sepolia transactions (#1201) #1236

arianejasuwienas commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 •

edited

Loading

Nana-EC left a comment

Nana-EC Feb 14, 2025

Nana-EC Feb 14, 2025

Nana-EC Feb 14, 2025

Nana-EC Feb 14, 2025

Nana-EC Feb 15, 2025

Nana-EC Feb 15, 2025

Nana-EC Feb 15, 2025

Nana-EC Feb 15, 2025

Nana-EC Feb 15, 2025

Nana-EC Feb 15, 2025

Nana-EC Feb 15, 2025

	This is achieved by re-executing all Ethereum transaction on by one on local Hedera network. Each transaction is verified by states match.
	This is achieved by re-executing all Ethereum transaction one by one on a local Hedera network. Each transaction is verified by states match.

	3. For each block its miners and uncles are read. The reward for block calculated is sent to an account in Hedera using the `TransferTransaction` method from the Hashgraph SDK.
	3. For each block its miners and uncles are read. The reward for block calculated is sent to an account in Hedera using the `TransferTransaction` method from the Hashgraph SDK. This is necessary to ensure node account balances are accurate as Ethereum and Hedera rewards nodes in different ways.

		@@ -0,0 +1,20 @@
		import { axiosInstanceErigon } from '@/api/config';

feat: milestone 1 - replay 30% of all sepolia transactions (#1201) #1236

Are you sure you want to change the base?

feat: milestone 1 - replay 30% of all sepolia transactions (#1201) #1236

Conversation

arianejasuwienas commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 • edited Loading

Test Results

Nana-EC left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2025 •

edited

Loading