Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The gas: 10000000 definition should be removed from the hardhat.config #392

Closed
ebadiere opened this issue Sep 12, 2023 · 0 comments · Fixed by #696
Closed

The gas: 10000000 definition should be removed from the hardhat.config #392

ebadiere opened this issue Sep 12, 2023 · 0 comments · Fixed by #696
Assignees
@quiet-node
Labels
bug Something isn't working

Comments

@ebadiere
Copy link
Contributor

Description

HIP 584 should have improved estimating gas. The smart contracts tests still seem to need the gas definition. When removed some tests fail with Error: cannot estimate gas; transaction may fail or may require manual gas limit.

Steps to reproduce

  1. Remove the gas declaration in the hardhat.config: gas: 10000000,
  2. Run some smart contracts tests. The ERC1155.js has some test that will expose the issue.

Additional context

No response

Hedera network

other

Version

v0.4.0

Operating system

macOS
@ebadiere ebadiere added the bug Something isn't working label Sep 12, 2023
@ebadiere ebadiere mentioned this issue Sep 15, 2023
Merged
@quiet-node quiet-node mentioned this issue Mar 5, 2024
Merged
2 tasks
@quiet-node quiet-node linked a pull request Mar 5, 2024 that will close this issue
fix: removed gas config in hardhat.config.js (#392) #696
Merged
2 tasks
@quiet-node quiet-node self-assigned this Mar 6, 2024
quiet-node added a commit that referenced this issue Mar 6, 2024
@quiet-node
fix: removed gas config in hardhat.config.js (#392) (#696)
025d1ef 
fix: removed gas config in hardhat.config.js

Signed-off-by: Logan Nguyen <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quiet-node quiet-node

Labels
bug Something isn't working
Projects
Smart Contract Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removed gas config in hardhat.config.js (#392) hashgraph/hedera-smart-contracts
2 participants
@ebadiere @quiet-node