Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break Gradle plugin out of pbj-core and pbj-compiler #260

Open
rbair23 opened this issue May 30, 2024 · 1 comment
Open

Break Gradle plugin out of pbj-core and pbj-compiler #260

rbair23 opened this issue May 30, 2024 · 1 comment

Comments

@rbair23
Copy link
Member

rbair23 commented May 30, 2024

The PBJ project has a funky build due to the fact that it builds a plugin, and that plugin is part of the pbj-compiler project. I think we could instead rearrange the project such that:

root
  |
  - pbj-compiler
  - pbj-runtime
  - pbj-gradle-plugin
  - pbj-grpc-helidon
  - tests
    - pbj-integration-tests

The compiler depends on the runtime, the gradle plugin depends on both, and the helidon plugin depends on all three. There would be a single multi-project gradle build, and each of the above would be a different module.

@jjohannes
Copy link
Collaborator

I agree.

Additional note: we should check if integrationTests could be splitup into different kind of tests that are located in src/test (and maybe src/testIntegration) of the different projects instead of having it as a separate Gradle build project. Tests for the plugin can be executed using Gradle's TestKit. This would avoid some complicated setup of the separate build.

settings.gradle.kts should be in the root after this change to align with the structure of other Hashgraph repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants