Make hashcode and protobuf size cached, change model records to classes #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperpotts
changed the title
jasperpotts
force-pushed
the
337-performance
branch
from
d9f81b9 to
cc1e232
Compare
jasperpotts
force-pushed
the
343-hash-size-caching
branch
from
4596db2 to
648f4b0
Compare
jasperpotts
requested review from
OlegMazurov
and removed request for
rbarker-dev
artemananiev
reviewed
Jan 9, 2025
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jasperpotts <[email protected]>
…nd protobuf size. Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
jasperpotts
force-pushed
the
343-hash-size-caching
branch
from
7c9ec4c to
596bd1f
Compare
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
jasperpotts
changed the title
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java
Outdated
Show resolved
Hide resolved
# Conflicts: # pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java # pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java # pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/protobuf/CodecMeasureRecordMethodGenerator.java # pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/RpcMethodDefinition.java # pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/RpcServiceDefinition.java # pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/JsonBench.java # pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java # pbj-integration-tests/src/main/java/com/hedera/pbj/integration/NonSynchronizedByteArrayInputStream.java
Signed-off-by: jasperpotts <[email protected]>
There was a problem hiding this comment.
A couple suggestions to use printf instead of string concatenation in println.
Also noticed all of the generated code blocks now use tabs instead of spaces, which actually makes it pretty unreadable, particularly the larger code blocks which mix tabs and spaces a lot.
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/generators/ModelGenerator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
rbair23
approved these changes
Feb 14, 2025
| """.replace("$hashCodeManipulation", HASH_CODE_MANIPULATION).indent(DEFAULT_INDENT); | ||
| return $hashCode; | ||
| } | ||
| """.replace("$hashCodeManipulation", HASH_CODE_MANIPULATION) |
There was a problem hiding this comment.
Should $hashCode be replaced with a field name, too?
There was a problem hiding this comment.
Nevermind. I see $hashCode is a real field name (which is confusing, btw)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #343