Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 show add worker filter when none set for targets #2564

Conversation

cameronperera
Copy link
Collaborator

@cameronperera cameronperera commented Nov 13, 2024

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15760

Description

show add worker filter when none set for targets

Screenshots (if appropriate)

Before:
Screenshot 2024-11-13 at 10 10 32 AM
After:
Screenshot 2024-11-13 at 10 11 12 AM

How to Test

  1. Navigate to workers tab on a Target
  2. If there is no worker filter set, it should say "Add worker filter". If there is a worker filter it should say "Edit worker filter".
  3. If you add or remove a worker filter, the text should change respectively.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Nov 13, 2024
@cameronperera cameronperera requested a review from a team as a code owner November 13, 2024 16:11
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:12pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:12pm

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@cameronperera cameronperera merged commit f9ba4f7 into llb/worker-filter-improvements Nov 13, 2024
11 checks passed
@cameronperera cameronperera deleted the ICU-15760-target-worker-filters-ui-update branch November 13, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants