Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul client pods by scraping annotations are not valid for TLS in Helm chart #4163

Open
SrivatsaSrinivas opened this issue Jul 10, 2024 · 0 comments
Labels
type/bug Something isn't working

Comments

@SrivatsaSrinivas
Copy link

SrivatsaSrinivas commented Jul 10, 2024

Description:
Issue Description:

Currently, the Helm chart for Consul client daemonset lacks proper prometheus annotations to enable metrics scraping if tls is enabled. This functionality is crucial for scraping metrics from Consul clients within a Kubernetes cluster.
https://github.com/hashicorp/consul-k8s/blob/main/charts/consul/templates/client-daemonset.yaml#L91C6-L100C19
Expected Behaviour:
Consul client pods should be able to automatically scrape metrics from 8501 port and with "https" scheme if TLS settings is enabled.

Steps to Reproduce:

Deploy Consul client pods with TLS enabled using the current Helm chart.

Notice that the prometheus scrape annotations are pointed to "8500" port and uses "http" scheme even if TLS is enabled.

Proposed Solution:

Modify the Helm chart to include check for TLS and configure scraping annotation based on that.(similar to consul server statefulset helm configuration)
https://github.com/hashicorp/consul-k8s/blob/main/charts/consul/templates/server-statefulset.yaml#L134C9-L147C19

Environment Details:

Kubernetes version: EKS 1.25
Helm version: 1.2.3
Consul version: 1.16.3

@SrivatsaSrinivas SrivatsaSrinivas added the type/bug Something isn't working label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant