Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose latest matched version #201

Open
radeksimko opened this issue May 1, 2024 · 0 comments
Open

Expose latest matched version #201

radeksimko opened this issue May 1, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@radeksimko
Copy link
Member

Background

When installing a latest version e.g. via

or even when discovering existing installation e.g. via fs.Version

it is currently impossible for the consumer to tell what version was installed after calling Install, Ensure or Find without executing the binary while the library internally already has the knowledge of the matched version.

Proposal

Expose matched version for the consumer

Considerations

This may require some breaking changes, e.g. returning a struct { ExecPath string, Version *version.Version } instead of just string (exec path) from the various methods like Install, Ensure and Find per https://pkg.go.dev/github.com/hashicorp/[email protected]/src

@radeksimko radeksimko added the enhancement New feature or request label May 1, 2024
radeksimko added a commit that referenced this issue May 7, 2024
Note this will also aid us to return other metadata such as version as per #201
radeksimko added a commit that referenced this issue May 7, 2024
Note this will also aid us to return other metadata such as version as per #201
radeksimko added a commit that referenced this issue May 8, 2024
Note this will also aid us to return other metadata such as version as per #201
@radeksimko radeksimko added this to the v1.0.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant