Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Levant incorrectly marks deployment as failed if dead:complete #224

Open
jrasell opened this issue Aug 7, 2018 · 1 comment · May be fixed by #420
Open

[bug] Levant incorrectly marks deployment as failed if dead:complete #224

jrasell opened this issue Aug 7, 2018 · 1 comment · May be fixed by #420
Labels
stage/accepted theme/deploy Relates to the deployment of jobs type/bug

Comments

@jrasell
Copy link
Member

jrasell commented Aug 7, 2018

Description

During batch job deployments with multiple tasks in a group that finish quickly and using the force-batch flag Levant incorrectly exits with status 1. This is because the job status checker is only looking for the is taking the job status = dead to mean failed; whereas this can coincide with client status complete indicating the job finished successfully.
@jrasell jrasell self-assigned this Aug 7, 2018
@publysher
Copy link

This can also happen without force-batch and having tasks in multiple groups.

Example:

job "test" {
  datacenters = ["..."]

  type = "batch"

  group "quick" {
    task "quick" {
      driver = "exec"
      config {
        command = "sleep"
        args = ["1"]
      }
      resources = {
        cpu    = 100
        memory = 50
      }
    }
  }

  group "slow" {
    task "slow" {
      driver = "exec"
      config {
        command = "sleep"
        args = ["120"]
      }
      resources = {
        cpu    = 100
        memory = 50
      }
    }
  }
}

@jrasell jrasell added stage/accepted theme/deploy Relates to the deployment of jobs type/bug and removed bug labels Nov 27, 2020
@jrasell jrasell removed their assignment Nov 27, 2020
@Seros Seros linked a pull request Sep 9, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage/accepted theme/deploy Relates to the deployment of jobs type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for TaskState.Failed if deployment has failed Seros/levant
2 participants
@publysher @jrasell