Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty log lines in journald (fixes #339) #376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix empty log lines in journald (fixes #339) #376

wants to merge 1 commit into from

Conversation

adriaandens
Copy link
Contributor

@adriaandens adriaandens commented Aug 1, 2024 •
edited
Loading

Problem: When using the journald logging, empty loglines are added by nomad. (resolves #339 )

before:
empty_loglines

after:
empty_loglines_fixed

@adriaandens adriaandens requested a review from a team as a code owner August 1, 2024 19:35
@courtland
Copy link
Contributor

Thanks for this!

FWIW I also noticed this start happening when moving from podman 3.x to 4.x - thought it was just something wrong with my environment.

@adriaandens
Copy link
Contributor Author

If it's a fix that happened in podman at a certain version, I can try to pass around the podman version and make the newline fix conditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty lines in alloc logs when logging.driver is journald
2 participants
@adriaandens @courtland