Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iso_download_pve should also work for additional_iso_files #234

Open
vincentKool opened this issue Sep 29, 2023 · 0 comments
Open

iso_download_pve should also work for additional_iso_files #234

vincentKool opened this issue Sep 29, 2023 · 0 comments

Comments

@vincentKool
Copy link

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

When setting the boolean iso_download_pve to true (default is false) Packer will delegate the downloading of the "main" iso to Proxmox. As far as I can see it is not possible for the additional ISO files to be downloaded by Proxmox. The setting iso_download_pve is not checked in the packer-plugin-proxmox/builder/proxmox/common/builder.go file before adding the downloading and uploading task.

Use Case(s)

If the ISO's are not yet on the machine running Packer, but are on the Proxmox server a lot of unnecessary downloading and uploading can be avoided.

Potential configuration

either use the iso_download_pve as a global value or add it as a variable to the additional_iso_file block

# Example of adding it to the additional_iso_file block

additional_iso_files {
    device = "sata4"
    iso_checksum = "946a6077af6f5f95a51f82fdc44051c7aa19f9cfc5f737954845a6050543d7c2"
    iso_url = "https://ubuntu.org/.../ubuntu-14.04.1-server-amd64.iso"
    unmount = true
+   iso_download_pve = true
}

Potential References

Proxmox API documentation | download-url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant