Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "TPM State" option for system #73

Closed
gihov opened this issue Mar 8, 2022 · 14 comments · Fixed by #260
Closed

Add support for "TPM State" option for system #73

gihov opened this issue Mar 8, 2022 · 14 comments · Fixed by #260

Comments

@gihov
Copy link

gihov commented Mar 8, 2022

Description

Allow to set the "TPM" flag with version and storage if enable, when building images using this plugin. The version is by default "v2.0" but can be "v1.2".

Use Case(s)

Enabling this option allow user to get access to Windows11 VM on proxmox, since it require TPM to be installed.

Potential configuration

"os": "win11",
"machine": "q35",
"bios": "ovmf",
"efidisk": "local",
"tpm": true,
"tpm_storage": "local"

tpm_version: "v1.2" if needed but staying on v2.0 by default.

Potential References

Proxmox documentation (section 10.2.11) : https://pve.proxmox.com/pve-docs/pve-admin-guide.html#qm_virtual_machines_settings
It looks like qm set <vmid> -tpmstate0 <storage>:1,version=<version> currently to set TPM on proxmox.

@gihov gihov changed the title Add support for "TPM State" option for system #69 Add support for "TPM State" option for system Mar 8, 2022
@alexanderek
Copy link

any news?

@woloss
Copy link

woloss commented Oct 31, 2022

Looks like proxmox-api-go still without TPM part, therefore no functionality for terraform, packer.

However, would be nice to be able to make W11 template or W2022 with vTPM in near future.

@altmeista
Copy link

Looks like proxmox-api-go still without TPM part, therefore no functionality for terraform, packer.

However, would be nice to be able to make W11 template or W2022 with vTPM in near future.

There's a workaround for windows machines like windows 11 by adding a registry entry via the autounattend.xml file during install process. Works for me by now, but TPM support would be better of course.

@newedgex
Copy link

newedgex commented Sep 1, 2023

This is a must for windows 11 builds

@TuncTaylan
Copy link

Pinging...

@Puben
Copy link

Puben commented Oct 3, 2023

Also here to show my interest in adding support for TPM using the Proxmox builder.

@mac641
Copy link

mac641 commented Jan 3, 2024

Also waiting for this to be added...

@niliopoulos89
Copy link

also waiting for this...

@ChrisDek
Copy link

+1 to the list of people who need to build real windows 11 machines without any hacks, so I need vTPM support in the builder. The vsphere-iso builder has this for a long time now

@vonMort
Copy link

vonMort commented Feb 16, 2024

+1 for this. A really needed improvement.

@FMRZDK
Copy link

FMRZDK commented Feb 16, 2024

+1 really needed here.

@R8bit
Copy link

R8bit commented Feb 19, 2024

+1 same here, would love to see this finally added

@mpywell
Copy link
Contributor

mpywell commented Mar 13, 2024

Submitted a PR to upstream telmate-api-go to handle TPM config in API calls. If merged will submit a PR for TPM in packer-plugin-proxmox.

Telmate/proxmox-api-go#241
Telmate/proxmox-api-go#321

@Torqu3Wr3nch
Copy link

Great work, @mpywell! This release is shaping up to have some great new features for the Proxmox builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.