-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Add community maintained IPSW data source Packer plugin #12541
website: Add community maintained IPSW data source Packer plugin #12541
Conversation
Ping. What's needed to move this forward? Thanks! |
85ee8f9
to
a1b1ab1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @torarnv,
Sorry for letting this one slide, I'll merge it today.
Please note however that we have changed our documentation practices recently, we don't have yet a documentation available for all the plugin developers to work with, but this will be published soon.
In the meantime, I'll merge your PR, and do the necessary steps on our infra code to make it accessible for users of the plugin.
Thanks!
Thanks @lbajolet-hashicorp ! |
@lbajolet-hashicorp Maybe I misunderstood, but were #12648 and #12647 the parts that made the plugin docs available in the current doc infra? It doesn't seem to pop up in the preview at https://packer-4c6dbhdhh-hashicorp.vercel.app/packer/integrations?tiers=community&components=data-source, nor in the current official docs at https://developer.hashicorp.com/packer/integrations?product_intent=packer&tiers=community&components=data-source No rush, just trying to understand where to look/find them at some point 😃 |
Hi @torarnv, So, in the past you'd have just needed to merge this, and we'd backport it to the website for it to be available, and it would happen in a not too long delay (depends on when the docs get refreshed based on that branch). Nowadays with the In the meantime, I would think you can access the docs directly, they should already be available (can confirm they are: https://developer.hashicorp.com/packer/plugins/datasources/ipsw). They will become more visible once the PR I opened is merged, and we'll update the docs guides to account for the changes we made in order to adopt the new docs system. Hope that helps, I would expect the plugin to be visible by next week, but please feel free to reping us on this PR by late next week if it's still not there, at that point we'll see what we can do to unblock that. |
Awesome, thank you so much @lbajolet-hashicorp ❤️ |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
No description provided.