Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Feature Request: Support Launch-Templates for t2/t3 unlimited configuration #103

Open
eedwards-sk opened this issue Nov 28, 2018 · 5 comments

Comments

@eedwards-sk
Copy link
Contributor

eedwards-sk commented Nov 28, 2018

Launch Configurations do not support configuring t2.unlimited or t3 bursting

This is due to AWS only supporting configuration of these options through launch templates.

This is a feature request to add support to use launch templates rather than launch configurations.

This is known to be a backwards incompatible change, thus this may be something for a much later release (major).

Edit: https://docs.aws.amazon.com/autoscaling/ec2/userguide/replace-launch-config.html

because AWS does describe a way to go from configuration to template, perhaps using some terraform logic we could create an upgrade path?

@eedwards-sk
Copy link
Contributor Author

relevant issue: hashicorp/terraform-aws-vault#97

looks like our best bet for getting this implemented will be with 0.12+

@brikis98
Copy link
Collaborator

+1. Adding this with 0.12 should be a whole lot easier.

@acsrujan
Copy link

Hey, can this be revisited?

I'm not here for t3.unlimited but AWS raised an alarm saying ASG doesn't have a launch template.

@robmorgan
Copy link
Collaborator

Hi @acsrujan we don't have any time to work on this at the moment, but we're happy to review any PRs if you want to look into it?

@acsrujan
Copy link

Thanks @robmorgan

Added a quick draft PR #176

Will mark it as ready for review after following guidelines and testing it whenever I get time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants