cdktf: synth --hcl fails to render false(bool), 0(int), ""(empty string)

[tenminus11]

Expected Behavior

false should come as a parameter instead it is empty in hcl, it is present in .json
"" empty string in resource and module also fails to render
0 value also fails to render in module

module "prj_vpc-host-hub" {
  billing_account                = "${var.billing_id}"
  enable_shared_vpc_host_project = false
  folder_id                      = "${google_folder.fldr_Common.name}"
  name                           = "vpc-host-hub"
  org_id                         = "${var.organization_id}"
  source                         = "terraform-google-modules/project-factory/google"
  version                        = "~> 15.0"
}

Actual Behavior

module "prj_vpc-host-hub" {
  billing_account                = "${var.billing_id}"
  enable_shared_vpc_host_project =
  folder_id                      = "${google_folder.fldr_Common.name}"
  name                           = "vpc-host-hub"
  org_id                         = "${var.organization_id}"
  source                         = "terraform-google-modules/project-factory/google"
  version                        = "~> 15.0"
}

Steps to Reproduce

projects_arg = {
                "name": project,
                "org_id": organization_id.string_value,
                "billing_account": billing_id.string_value,
                "enable_shared_vpc_host_project": False,
                **proj_param,
            }
ProjectFactory(self, f"prj_{project}", **projects_arg)

Versions

anguage: python
cdktf-cli: 0.20.7
node: v20.12.2
cdktf: 0.20.7
constructs: 10.3.0
jsii: 1.98.0
terraform: 1.5.6
arch: x64
os: linux 6.6.15-2rodete2-amd64
python: Python 3.11.8
pip: pip 24.0 from xxxxxxx/lib/python3.11/site-packages/pip (python 3.11)
pipenv: pipenv, version 2023.12.1
providers
google@~> 5.28.0 (LOCAL)
terraform provider version: 5.28.0
cdktf-cdktf-provider-google (PREBUILT)
terraform provider version: 5.27.0
prebuilt provider version: 13.16.0
cdktf version: ^0.20.0

Providers

┌───────────────┬──────────────────┬─────────┬────────────┬─────────────────────────────┬─────────────────┐
│ Provider Name │ Provider Version │ CDKTF │ Constraint │ Package Name │ Package Version │
├───────────────┼──────────────────┼─────────┼────────────┼─────────────────────────────┼─────────────────┤
│ google │ 5.28.0 │ │ ~> 5.28.0 │ │ │
├───────────────┼──────────────────┼─────────┼────────────┼─────────────────────────────┼─────────────────┤
│ google │ 5.27.0 │ ^0.20.0 │ │ cdktf-cdktf-provider-google │ 13.16.0 │
└───────────────┴──────────────────┴─────────┴────────────┴─────────────────────────────┴─────────────────┘

Gist

No response

Possible Solutions

No response

Workarounds

No response

Anything Else?

No response

References

No response

Help Wanted

• I'm interested in contributing a fix myself

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[tenminus11]

false fails to render in module
"" empty string fails to render in resource and module
0 value also fails to render in module

[tenminus11]

@mutahhir Thanks for fixing falsy value hcl render issue in modules
I observed similar bug in locals, variable and resource
resource with "" empty string does not render in hcl
variable default 0,false,"" does not render in hcl
local with value 0,false,"" does not render in hcl
#3673

[mutahhir]

I'm not sure what's going on here. We actually have a test around this exact thing which is passing right now. Can you give me exact reproduction steps for this?

[XIAOLONGLII]

Still seeing this issue....
(For cdktf synth --hcl only. cdktf synth works since it is generating json)

CDKTF code:

new TerraformVariable(this, "A", {
  type: "string",
  default: false
});

new TerraformVariable(this, "B", {
  type: "bool",
  default: false
});

None of this will generate the default value, it will be no default when generated the Terraform HCL:

HCL:

variable "A" {
 type = string
}

variable "B" {
 type = bool
}

# default is not being generated

@mutahhir
@tenminus11

[XIAOLONGLII]

I'm not sure what's going on here. We actually have a test around this exact thing which is passing right now. Can you give me exact reproduction steps for this?

so at your test:

 module "test" {
    false_boolean = false
    true_boolean = true
    zero_number = 0
    empty_string = ""
    module_parameter = "myParam"
    source = "my-module"
    version = "1.0"
    providers = {
    test = "test.provider1"
    }

So you only tested within the module, when it is inside of module, it will work!
false_boolean will get false generated.

However, when it is a standalone variable (outside of module), it won't get generated...

i haven't tested the terraformlocal yet....but TerraformVariable for default definitely not working...... for the newest version: v0.21.0 or older.