You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar to #933 there might be other tftypes package Transform()/Walk() logic which may or may not be fully handling the error return properly. While most of this sort of logic in the framework should be returning diagnostics to wrapping logic rather than error back to the Transform()/Walk() caller, there are cases where tftypes.Value can get errantly set, especially in the case of dynamic types.
Proposal
Double check Transform()/Walk() for error return handling, including:
NullifyCollectionBlocks
ReifyNullCollectionBlocks
Any others
The error return should be converted into a "unexpected" error diagnostic so provider developers and framework maintainers can more easily determine triage steps, rather than the potential for other unexpected behavior.
Module version
Use-cases
Similar to #933 there might be other
tftypes
packageTransform()
/Walk()
logic which may or may not be fully handling theerror
return properly. While most of this sort of logic in the framework should be returning diagnostics to wrapping logic rather thanerror
back to theTransform()
/Walk()
caller, there are cases wheretftypes.Value
can get errantly set, especially in the case of dynamic types.Proposal
Double check
Transform()
/Walk()
forerror
return handling, including:NullifyCollectionBlocks
ReifyNullCollectionBlocks
The
error
return should be converted into a "unexpected" error diagnostic so provider developers and framework maintainers can more easily determine triage steps, rather than the potential for other unexpected behavior.References
The text was updated successfully, but these errors were encountered: