Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Plan Checks for Generic Resource/Output Changes #233

Open
bflad opened this issue Nov 30, 2023 · 0 comments
Open

Consider Plan Checks for Generic Resource/Output Changes #233

bflad opened this issue Nov 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bflad
Copy link
Contributor

bflad commented Nov 30, 2023

terraform-plugin-testing version

v1.5.1

Use cases

This Go module provides a few abstractions for asserting whether providers are planning a change that will affect state:

In #222, it was noted that due to their naming ExpectEmptyPlan and ExpectNonEmptyPlan should be capturing all plan changes that would affect the saved state -- both resource changes and output changes. However, there could be situations where developers want to write generic assertions against only resource changes or only output changes being expected (or not) to occur. This feature request is here to capture interest and use cases.

Proposal

Introduce separate, but still generic plan checks against any/all resource/output changes, e.g.

  • plancheck.ExpectNoOutputChanges()
  • plancheck.ExpectNoResourceChanges()
  • plancheck.ExpectOutputChanges()
  • plancheck.ExpectResourceChanges()

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant