ebs_optimized in resource_aws_launch_template doesn't accept string true/false

[kinghuang]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.11.8

• provider.aws v1.37.0

Affected Resource(s)

• aws_launch_template

Terraform Configuration Files

resource "aws_launch_template" "managers" {
  name = "${var.name}-managers"
  image_id      = "${data.aws_ami_ids.moby.ids[0]}"
  instance_type = "${var.manager_instance_type}"

  …

  block_device_mappings {
    device_name = "/dev/xvdb"
    ebs {
      volume_type = "${var.manager_disk_type}"
      volume_size = "${var.manager_disk_size}"
    }
  }
  ebs_optimized = "true"
}

Debug Output

Error: module.swarm.aws_launch_template.managers: expected ebs_optimized to be
one of ["", false, true], got true

Panic Output

N/A

Expected Behavior

ebs_optimized should be true.

Actual Behavior

An error occurred using the string "true" for ebs_optimized.

Steps to Reproduce

1. terraform apply

Important Factoids

While upgrading from version 1.35.0 to 1.37.0 of the AWS provider, I ran into this error with the ebs_optimized parameter in the aws_launch_template resource. I'm using the string value "true", but that resulted in the error that the value was expected to be one of ["", false, true]. Changing the value to boolean value true worked.

From 1.35.0 to 1.36.0, the value type for ebs_optimized change from schema.TypeBool to schema.TypeString (eeb04c6), and uses validateTypeStringNullableBoolean for ValidateFunc. The new validation function doesn't seem to allow for string "true" and "false" values.

References

Change of ebs_optimized's value type and validation function: 2e8a2b3
Addition of validateTypeStringNullableBoolean: #5632

[bflad]

Hi @kinghuang 👋 Sorry for the trouble. We generally try to prevent configuration regressions such as this although the usage of the string versions of "true"/"false" is less likely to be accounted for.

I think we can safely add "false" and "true" to the new validation function, I'm working on verifying that.

[bflad]

The fix for this has been merged and will release with version 1.38.0 of the AWS provider, likely later today.

[kinghuang]

Awesome. Thanks for the quick turnaround!

[bflad]

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!