tests/provider: Use Standard Terraform Plugin SDK TestCheckFunc

[bflad]

Terraform Version

N/A (provider acceptance testing)

Affected Resource(s)

• local_file

Expected Behavior

Testing would use available Terraform Plugin SDK TestCheckFunc where possible.

Actual Behavior

Certain places are manually checking the Terraform state values instead of using helpers, such as helper/resource.TestCheckResourceAttr().

References

• terraform-provider-local/internal/provider/data_source_local_file_test.go

  Lines 38 to 48 in 528138f

  	Check: func(s *terraform.State) error {
  	m := s.RootModule()
  	i := m.Resources["data.local_file.file"].Primary
  	if got, want := i.Attributes["content"], test.content; got != want {
  	return fmt.Errorf("wrong content %q; want %q", got, want)
  	}
  	if got, want := i.Attributes["content_base64"], base64.StdEncoding.EncodeToString([]byte(test.content)); got != want {
  	return fmt.Errorf("wrong content_base64 %q; want %q", got, want)
  	}
  	return nil
  	},