Skip to content

Latest commit

 

History

History
58 lines (42 loc) · 2.54 KB

CONTRIBUTING.md

File metadata and controls

58 lines (42 loc) · 2.54 KB
Raw

Contributing to vault-client-go

Please note: We take Vault's security and our users' trust very seriously. If you believe you have found a security issue in Vault, please responsibly disclose by contacting us at [email protected].

First: if you're unsure or afraid of anything, just ask or submit the issue or pull request anyways. You won't be yelled at for giving it your best effort. The worst that can happen is that you'll be politely asked to change something. We appreciate any sort of contributions, and don't want a wall of rules to get in the way of that.

That said, if you want to ensure that a pull request is likely to be merged, talk to us! You can find out our thoughts and ensure that your contribution won't clash or be obviated by Vault's normal direction. A great way to do this is via the vault discussion forum.

Issues

  • Make sure you test against the latest released version. It is possible we already fixed the bug you're experiencing. Even better is if you can test against the main branch, as the bugs are regularly fixed but new versions are only released every few months.

  • Provide steps to reproduce the issue, and, if possible, include the expected results as well as the actual results. Please provide text, not screen shots!

  • Respond as promptly as possible to any questions made by the Vault team to your issue.

Pull requests

When submitting a PR you should reference an existing issue. If no issue already exists, please create one. This can be skipped for trivial PRs like fixing typos.

Creating an issue in advance of working on the PR can help to avoid duplication of effort, for example, maybe we know of existing related work. Alternatively, it may be that we can provide guidance that will help with your approach.

Your pull request should have a description of what it accomplishes, how it does so, and why you chose the approach you did. PRs should include unit tests that validate correctness and the existing tests must pass. Follow-up work to fix tests does not need a fresh issue filed.

Someone will do a first pass review on your PR making sure it follows the guidelines in this document. If it doesn't we'll mark the PR incomplete and ask you to follow up on the missing requirements.

Contributor License Agreement

We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution.

Learn more about why HashiCorp requires a CLA and what the CLA includes.