Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate hnix-store-benchmark from #26 and hnix-store-dump as executables #233

Open
Tracked by #247
sorki opened this issue Nov 17, 2023 · 4 comments
Open
Tracked by #247
Labels
good first issue nar `hnix-store-nar` related

Comments

@sorki
Copy link
Member

sorki commented Nov 17, 2023

The thingie is pretty self-contained and doesn't even seem to depend on -core. The ReadonlyStore depends on it but that should also be a separate package it seems.

This would make dependencies cleaner and maintenance a bit easier.

CC @imalsogreg @domenkozar @sandydoo - I would add you all as maintainers on Hackage. Thoughts?

@sorki sorki added the nar `hnix-store-nar` related label Nov 17, 2023
@sorki
Copy link
Member Author

sorki commented Nov 17, 2023

Could also include hnix-store-benchmark from #26 and hnix-store-dump as executables.

@sorki
Copy link
Member Author

sorki commented Nov 17, 2023

Could also include hnix-store-benchmark from #26 and hnix-store-dump as executables.

Since the thingie is a lib they should be guarded with flags like in -dbs cabal + buildable so they won't propagate to users PATH by default but enabled in dev env via cabal.project

@sorki
Copy link
Member Author

sorki commented Nov 22, 2023

When this lands on Hackage, the migration path for cachix is simple:

  • add lower bound to hnix-store-core to require >= 0.8
  • add hnix-store-nar

@sorki sorki reopened this Nov 22, 2023
@sorki sorki changed the title Split off Nar into hnix-store-nar Integrate hnix-store-benchmark from #26 and hnix-store-dump as executables Nov 22, 2023
@sorki
Copy link
Member Author

sorki commented Nov 22, 2023

Keeping open as the exe and benchmark would be cool! I think Domen and Sander wouldn't mind if this is picked from their repos and added here with git commit --author=... attribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue nar `hnix-store-nar` related
Projects
None yet
Development

No branches or pull requests

1 participant