Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Redundant as" in our lexer #10581

Closed
philderbeast opened this issue Nov 22, 2024 · 0 comments · Fixed by #10582
Closed

"Redundant as" in our lexer #10581

philderbeast opened this issue Nov 22, 2024 · 0 comments · Fixed by #10582
Labels
needs triage type: bug

Comments

@philderbeast
Copy link
Collaborator

I stumbled on this one. HLint is warning about "Redundant as" in our lexer.

cabal/Cabal-syntax/src/Distribution/Fields/Lexer.x

Line 23 in c3a9dd7

import qualified Prelude as Prelude 

$ hlint dist-newstyle-validate-ghc-9.10.1-before/build/x86_64-linux/ghc-9.10.1/Cabal-syntax-3.15.0.0/build/Distribution/Fields/Lexer.hs
Warning: Can't find file "ghcconfig.h" in directories
	dist-newstyle-validate-ghc-9.10.1-before/build/x86_64-linux/ghc-9.10.1/Cabal-syntax-3.15.0.0/build/Distribution/Fields
	.
  Asked for by: dist-newstyle-validate-ghc-9.10.1-before/build/x86_64-linux/ghc-9.10.1/Cabal-syntax-3.15.0.0/build/Distribution/Fields/Lexer.hs  at line 46 col 1
src/Distribution/Fields/Lexer.x:22:1-35: Suggestion: Redundant as
Found:
  import qualified Prelude as Prelude
Perhaps:
  import qualified Prelude

1 hint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use redundant alias Prelude as Prelude cabalism/cabal
1 participant
@philderbeast