Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use shallow clones for source-repository-packages #10619

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

9999years
Copy link
Collaborator

Fixes #10605

Includes a regression test.

@philderbeast
Copy link
Collaborator

philderbeast commented Dec 7, 2024

I checked out this branch, installed cabal-install from it and reran a timing test against amazonka, same as #10605 (comment). This gives slow results. I ran it twice after cleaning and got 82s and 84s. I reran the same test twice using cabal-install from the master branch, at 1f52963, and got times of, 16s each time.

@9999years
Copy link
Collaborator Author

@philderbeast Yes, that's what I'm expecting. It might be possible to keep the shallow clone behavior in some cases without introducing regressions, but let's fix the regressions first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New git invocation changes the behaviour of source-repository-package
2 participants