Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-mode-find-def failing; additional quote characters needed; fix included #1856

Open
genovese opened this issue Nov 1, 2024 · 0 comments

Comments

@genovese
Copy link

genovese commented Nov 1, 2024

With recent versions of GHC, the :info name command returns a module name in quotes that are unicode characters (in particular x2018 ‘ and x2019 ’). The matching in haskell-mode-find-def only has the ASCII `' quotes.

In line 443 in the current HEAD

    (string-match "`\\(.+?\\):\\(.+?\\)'$" defined)

could be changed to

    (string-match "[`‘]\\(.+?\\):\\(.+?\\)['’]$" defined)

and in line 448 in the current HEAD

    (string-match "`\\(.+?\\)'$" defined))

could be changed to

    (string-match "[`‘]\\(.+?\\)['’]$" defined)

When making these changes only, haskell-mode-find-def now works, whereas before it returned nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant