Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peers.allowed_ips and peers.client_allowed_ips are not optional #262

Closed
twerner opened this issue Sep 20, 2023 · 1 comment · May be fixed by #315
Closed

peers.allowed_ips and peers.client_allowed_ips are not optional #262

twerner opened this issue Sep 20, 2023 · 1 comment · May be fixed by #315
Labels
stale There has not been activity on this issue or PR for quite some time.

Comments

@twerner
Copy link

twerner commented Sep 20, 2023

Problem/Motivation

I created a new VPN connection without peers.allowed_ips and peers.client_allowed_ips, but I was unable to save it without them.

Expected behavior

I expected to not need them. The documentation states for peers.allowed_ips:

If there are no IP addresses configured, the add-on will use the addresses listed in peers.addresses.

and for peers.client_allowed_ips:

If not configured, the add-on will use 0.0.0.0/0 in the generated client configuration, routing all traffic on your client through the VPN tunnel.

Actual behavior

I received the following two errors respectively:

Failed to save add-on configuration, Missing option 'allowed_ips' in peers in WireGuard (a0d7b954_wireguard).

Failed to save add-on configuration, Missing option 'client_allowed_ips' in peers in WireGuard (a0d7b954_wireguard).

Steps to reproduce

Remove allowed_ips and client_allowed_ips from a configuration, and attempt to save.

Proposed changes

Update the documentation to mark them as required, or ensure the stated defaults are enforced.
@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
thijzert added a commit to thijzert/addon-wireguard that referenced this issue May 30, 2024
@thijzert
Mark fields "allowed_ips" and "client_allowed_ips" as required
91f0027 
The add-on refuses to start without them. This fixes hassio-addons#262
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stale There has not been activity on this issue or PR for quite some time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark fields "allowed_ips" and "client_allowed_ips" as required thijzert/addon-wireguard
1 participant
@twerner