diff --git a/Cargo.lock b/Cargo.lock index 5c86130..8bee3a2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -954,7 +954,7 @@ dependencies = [ [[package]] name = "ndc-models" version = "0.1.4" -source = "git+http://github.com/hasura/ndc-spec.git?branch=samirtalwar/bump#ba1559e131f5cc8d0563fbbc947508ec17dcd91e" +source = "git+http://github.com/hasura/ndc-spec.git?tag=v0.1.4#20172e3b2552b78d16dbafcd047f559ced420309" dependencies = [ "indexmap 2.2.6", "schemars", @@ -999,7 +999,7 @@ dependencies = [ [[package]] name = "ndc-test" version = "0.1.4" -source = "git+http://github.com/hasura/ndc-spec.git?branch=samirtalwar/bump#ba1559e131f5cc8d0563fbbc947508ec17dcd91e" +source = "git+http://github.com/hasura/ndc-spec.git?tag=v0.1.4#20172e3b2552b78d16dbafcd047f559ced420309" dependencies = [ "async-trait", "clap", diff --git a/crates/sdk/Cargo.toml b/crates/sdk/Cargo.toml index 3970f67..451ca0e 100644 --- a/crates/sdk/Cargo.toml +++ b/crates/sdk/Cargo.toml @@ -24,8 +24,8 @@ rustls = ["reqwest/rustls"] ndc-test = ["dep:ndc-test"] [dependencies] -ndc-models = { git = "http://github.com/hasura/ndc-spec.git", branch = "samirtalwar/bump" } -ndc-test = { git = "http://github.com/hasura/ndc-spec.git", branch = "samirtalwar/bump", optional = true } +ndc-models = { git = "http://github.com/hasura/ndc-spec.git", tag = "v0.1.4" } +ndc-test = { git = "http://github.com/hasura/ndc-spec.git", tag = "v0.1.4", optional = true } async-trait = "0.1.79" axum = { version = "0.6.20", features = ["http2"] } diff --git a/crates/sdk/src/connector/example.rs b/crates/sdk/src/connector/example.rs index fecf26e..ce7486a 100644 --- a/crates/sdk/src/connector/example.rs +++ b/crates/sdk/src/connector/example.rs @@ -60,6 +60,7 @@ impl Connector for Example { nested_fields: models::NestedFieldCapabilities { filter_by: None, order_by: None, + aggregates: None, }, }, mutation: models::MutationCapabilities { @@ -145,7 +146,8 @@ mod tests { assert_eq!(response.status(), StatusCode::OK); let body: ndc_models::CapabilitiesResponse = response.json().await; - assert_eq!(body.version, ndc_models::VERSION); + // ideally we would get this version from `ndc_models::VERSION` + assert_eq!(body.version, "0.1.4"); Ok(()) } }