Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip Files requires native tooling #33

Open
Rafiot opened this issue Jun 8, 2018 · 3 comments
Open

Gzip Files requires native tooling #33

Rafiot opened this issue Jun 8, 2018 · 3 comments

Comments

@Rafiot
Copy link

Rafiot commented Jun 8, 2018

Is there a reason you're not using the gzip module to handle pure gzip file? You do that for .tar.gz, so it is confusing.

And if not, do you mind if I implement a pure python module to handle simple gzip files without requiring 7zip?

@jbremer
Copy link
Member

jbremer commented Jun 8, 2018

Thanks, you're right! I think the most important aspect for me is keeping up performance; so preferably we have such pure Python implementation with opt-in 7z-based module, i.e., if 7z is installed it should opt for that method. This requires a bit more work, though.. feel free to PR as suggested in the meantime.

@Rafiot
Copy link
Author

Rafiot commented Jun 8, 2018

Sounds good, I'll push a PR ASAP

@jbremer
Copy link
Member

jbremer commented Jun 8, 2018

What I suggested is basically what I described in #25, BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants