-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add fs reviews #109
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice adding this bonus feature. A few minor comments have been left to take a look at.
<Grid item xs={12} sm={7}> | ||
<Card> | ||
<CardActionArea className={classes.media}> | ||
{/* TODO: Add coverPhoto and profilePhoto to the Profile Model, adjust to profile?.coverPhoto and profile?.profilePhoto accordingly. */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment if you're done using it
<Grid item xs={12} sm={7}> | ||
<Card> | ||
<CardActionArea className={classes.media}> | ||
{/* TODO: Add coverPhoto and profilePhoto to the Profile Model, adjust to profile?.coverPhoto and profile?.profilePhoto accordingly. */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment if you're done using it
<Typography variant="h6" align="center" className={classes.title}> | ||
$22/hr | ||
</Typography> | ||
{/* TODO: Create Rating Model and add the value. */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment if done with the todo
<Grid item xs={12} sm={5}> | ||
<Card className={classes.request}> | ||
<Box> | ||
{/* TODO: Add rate to the Profile Model, adjust to profile.rate. */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment if done with the todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with this! Just address Sunday's comments prior to merging. Thanks 😄
What this PR does:
Screenshots / Videos:
Screen.Recording.2021-11-07.at.4.53.46.AM.mov
Any information needed to test this feature:
dog owner
and 1dog sitter
already in the DB.dog owner
anddog sitter
with statusPAID
.Any issues with the current functionality:
SitterDetails.tsx
on line101
the function has manual parameter i.e.WALKING
and price22
which are being worked on in different issue/PR.closes #15