Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add fs reviews #109

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Feature add fs reviews #109

wants to merge 10 commits into from

Conversation

navjot-chahal
Copy link
Collaborator

What this PR does:

  • Adds FS for reviews features.

Screenshots / Videos:

  • See the demo for review creation and display.
Screen.Recording.2021-11-07.at.4.53.46.AM.mov

Any information needed to test this feature:

  • To test the feature there should be at least 1 dog owner and 1 dog sitter already in the DB.
  • To post a review for the sitter there must be a request document object present between dog owner and dog sitter with status PAID.

Any issues with the current functionality:

  • This PR brings changes from other contributors' work and some of the functionality has been hardcoded to make only this feature work.
  • Total functionality will work once the other feature from other contributors is merged.
  • For eg: In SitterDetails.tsx on line 101 the function has manual parameter i.e. WALKING and price 22 which are being worked on in different issue/PR.

closes #15

@navjot-chahal navjot-chahal linked an issue Nov 7, 2021 that may be closed by this pull request
Copy link

@sundayezeilo sundayezeilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice adding this bonus feature. A few minor comments have been left to take a look at.

<Grid item xs={12} sm={7}>
<Card>
<CardActionArea className={classes.media}>
{/* TODO: Add coverPhoto and profilePhoto to the Profile Model, adjust to profile?.coverPhoto and profile?.profilePhoto accordingly. */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment if you're done using it

<Grid item xs={12} sm={7}>
<Card>
<CardActionArea className={classes.media}>
{/* TODO: Add coverPhoto and profilePhoto to the Profile Model, adjust to profile?.coverPhoto and profile?.profilePhoto accordingly. */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment if you're done using it

<Typography variant="h6" align="center" className={classes.title}>
$22/hr
</Typography>
{/* TODO: Create Rating Model and add the value. */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment if done with the todo

<Grid item xs={12} sm={5}>
<Card className={classes.request}>
<Box>
{/* TODO: Add rate to the Profile Model, adjust to profile.rate. */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment if done with the todo

Copy link
Contributor

@rajivtitus rajivtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this! Just address Sunday's comments prior to merging. Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bonus FS: Reviews
3 participants