Feature add be pay route #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 8, 2021
Open
Open
sundayezeilo
reviewed
Nov 8, 2021
| const classes = useStyles(); | ||
|
|
||
| return ( | ||
| <label> |
There was a problem hiding this comment.
I think MUI has FormLabel component you can use. Not sure though, but you can find out.
Comment on lines
+18
to
+20
| // @route POST /payment/add | ||
| // @desc Add a new card to the list of payment methods | ||
| // @access Private |
Comment on lines
+40
to
+42
| // @route GET /payment/ | ||
| // @desc Get list of card for the given user | ||
| // @access Private |
Comment on lines
+65
to
+67
| // @route PATCH /payment/:cardId | ||
| // @desc Update the default card for payment | ||
| // @access Private |
Comment on lines
+65
to
+67
| // @route PATCH /payment/:cardId | ||
| // @desc Update the default card for payment | ||
| // @access Private |
Comment on lines
+107
to
+133
| await Promise.all( | ||
| Object.entries(input).map(async ([key, value]) => { | ||
| if (value) { | ||
| if (key === "status" && value === "PAID") return; | ||
| else if (key === "status" && value === "ACCEPTED") { | ||
| const charge = await stripe.charges.capture(request.chargeId); | ||
| if (charge.status === "failed") { | ||
| res.status(400); | ||
| } else { | ||
| request.status = "PAID"; | ||
| } | ||
| } else if (key === "status" && value === "DECLINED") { | ||
| if (!request.chargeId) { | ||
| res.status(400); | ||
| } | ||
| await stripe.refunds.create({ | ||
| charge: request.chargeId, | ||
| }); | ||
| request.status = "DECLINED"; | ||
| request.chargeId = null; | ||
| } else if (key === "startDate") { | ||
| request.startDate = new Date(value); | ||
| } else if (key === "endDate") { | ||
| request.endDate = new Date(value); | ||
| } else { | ||
| request[key] = value; | ||
| } |
There was a problem hiding this comment.
It would be a cleaner code to first map all the Promises and assign them to a variable, then pass the variable to Promise.all.
Comment on lines
+12
to
+14
| router.route("/add").post(protect, addCard); | ||
| router.route("/").get(protect, getCards); | ||
| router.route("/:cardId").patch(protect, UpdateDefaultCard); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
profile editpage to add payment options. Users can choose a default option for payment as well.Request from
dog owner=> Hold captured fromdog ownercard => Conversation between parties added => if sitter accepts thenOption Accept, if notOption Decline.Option Accept=> Charge thedog owner=> Set the request state toPAID.Option Decline=> Release the Hold amount => Set the request state toDECLINE.Screenshots / Videos:
Demobelow for the complete payment process.Screen.Recording.2021-11-08.at.12.34.48.AM.mov
Any information needed to test this feature:
Team Scallopsunder email:[email protected]and password:hatchwaysteamscallops2021@closes #5 , #22 , #34