DEV-1022 Remove Determinations Breakdown page #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove everything that reads or modifies `crms.determinationsbreakdown` and `crms.predeterminationsbreakdown`. - Remove the Determinations Breakdown page template and everything that inhabits it.
mwarin
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Checked out main and grepped for 'determinationsbreakdown|predeterminationsbreakdown' to get a feel for the "before" state. Switched to this feature branch and grepped again, and all occurrences from main seem to be gone.
Followed build instructions in README. We should probably start changing any docker-compose to (hyphen-less) docker compose, as the hyphenated form is falling out of supported use.
Test output is neat as a pin and passes.
It pains me to see line counts in the 4000s, I appreciate that you are trimming them.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crms.determinationsbreakdownandcrms.predeterminationsbreakdown.