Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 version #239

Merged
merged 10 commits into from
Dec 9, 2024
Merged

v2 version #239

merged 10 commits into from
Dec 9, 2024

Conversation

Jayprakash-SE
Copy link
Collaborator

No description provided.

@Jayprakash-SE Jayprakash-SE changed the title [WIP} v2 version [WIP] v2 version Nov 1, 2024
@Jayprakash-SE Jayprakash-SE changed the title [WIP] v2 version v2 version Nov 30, 2024
@Jayprakash-SE Jayprakash-SE requested a review from mahmoud December 3, 2024 20:16
Copy link
Member

@mahmoud mahmoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial questions, comments, and typographical fixes. Haven't looked at the vue very much, this is mostly around deployment. Also, you mentioned there may be some divergences from legacy re: configs (uwsgi?), can you highlight those here please?

deployment_v2.md Outdated Show resolved Hide resolved
deployment_v2.md Outdated Show resolved Hide resolved
deployment_v2.md Show resolved Hide resolved
deployment_v2.md Show resolved Hide resolved
dev_v2.md Outdated Show resolved Hide resolved
dev_v2.md Outdated Show resolved Hide resolved
dev_v2.md Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
Comment on lines +29 to +30
npm install
npm run toolforge:build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about how often things can change/break on toolforge, I'm wondering if it makes sense to document a way to build a production version locally and upload it using simple tools (without needing a whole node env)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played with fabric.I think we can easily zip the bundle locally and upload it to the tool with a webservice restart as we don't need to go inside pos.

@Jayprakash-SE
Copy link
Collaborator Author

Also, you mentioned there may be some divergences from legacy re: configs (uwsgi?), can you highlight those here please?

@mahmoud See https://github.com/hatnote/montage/tree/master/config

@mahmoud
Copy link
Member

mahmoud commented Dec 9, 2024

Also, you mentioned there may be some divergences from legacy re: configs (uwsgi?), can you highlight those here please?

@mahmoud See https://github.com/hatnote/montage/tree/master/config

is the concern around the slashes? has the url structure changed? i don't think we make a lot of promises about deeplinks/bookmarks, etc. We don't have public URLs besides login/home.

Other than that, the config only affects backend, if it's still used, even.

@mahmoud mahmoud merged commit 4a7eb9b into master Dec 9, 2024
@Jayprakash-SE
Copy link
Collaborator Author

Also, you mentioned there may be some divergences from legacy re: configs (uwsgi?), can you highlight those here please?

@mahmoud See https://github.com/hatnote/montage/tree/master/config

is the concern around the slashes? has the url structure changed? i don't think we make a lot of promises about deeplinks/bookmarks, etc. We don't have public URLs besides login/home.

Other than that, the config only affects backend, if it's still used, even.

There is no concern. The new version does not use the uwsgi.ini files but rather uses standard approach (https://wikitech.wikimedia.org/wiki/Help:Toolforge/Web/Python#Conventions).

My question was that I don't have experience with these config files so, in case of rollback. I may struggle to redeploy the app because I did the custom config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants