-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 version #239
v2 version #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial questions, comments, and typographical fixes. Haven't looked at the vue very much, this is mostly around deployment. Also, you mentioned there may be some divergences from legacy re: configs (uwsgi?), can you highlight those here please?
npm install | ||
npm run toolforge:build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking about how often things can change/break on toolforge, I'm wondering if it makes sense to document a way to build a production version locally and upload it using simple tools (without needing a whole node env)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played with fabric.I think we can easily zip the bundle locally and upload it to the tool with a webservice restart as we don't need to go inside pos.
@mahmoud See https://github.com/hatnote/montage/tree/master/config |
is the concern around the slashes? has the url structure changed? i don't think we make a lot of promises about deeplinks/bookmarks, etc. We don't have public URLs besides login/home. Other than that, the config only affects backend, if it's still used, even. |
There is no concern. The new version does not use the uwsgi.ini files but rather uses standard approach (https://wikitech.wikimedia.org/wiki/Help:Toolforge/Web/Python#Conventions). My question was that I don't have experience with these config files so, in case of rollback. I may struggle to redeploy the app because I did the custom config. |
No description provided.