Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create offer screen - Floatig price - Buy/Sell - %Above/%Below market price is not obvious it can be changed in both directions and wrong defaults #1233

Open
charcharchar opened this issue Aug 25, 2024 · 1 comment
Labels

Comments

@charcharchar
Copy link

When you create an offer to buy or sell for floating/market price, depending if you select to make a buy offer or sell offer, By default it displays %Above market price OR %below market price which may confuse people it can be in one direction only as its not intuitive to put a negative number.
Perhaps the wording for the text box should be update to display '%above / %below the market price' and change from free text box to a stepper ui element where arrows can be pressed to go up or down .5 percentage points.

As an aside, Currently It would seem the default for a create a buy, the taker/seller is offered below market rates(%below) and create a sell, the taker/buyer is offered above market rates (%above). the defaults are in the wrong directions, and this is why the order book currently has offers that are not attractive to buyers or sellers unless a negative percentage is placed in the below/above market price box.

@woodser
Copy link
Contributor

woodser commented Aug 25, 2024

As an aside, Currently It would seem the default for a create a buy, the taker/seller is offered below market rates(%below) and create a sell, the taker/buyer is offered above market rates (%above). the defaults are in the wrong directions, and this is why the order book currently has offers that are not attractive to buyers or sellers unless a negative percentage is placed in the below/above market price box.

It's confusing, I know, but this behavior is consistent with Bisq at least. Please let us know if you see any discrepancies from Bisq.

If creating an offer to buy XMR, the maker is offered to buy XMR below market rate. In which case, the taker/seller is offered to sell XMR below market rate as well.

If creating an offer to buy BTC / sell XMR, the maker is offered to buy BTC below market rate, in which case the taker/buyer is offered to buy XMR above market rate.

In this case, a negative percent always comes at the expense of the maker, and to the advantage of the taker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants