Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build app as a JPackage app-image before making other installers [0.5 XMR] #1280

Open
Jabster28 opened this issue Sep 16, 2024 · 8 comments
Open
Labels
a:CI About Continuous Integration 💰bounty There is a bounty on this issue

Comments

@Jabster28
Copy link
Contributor

Jabster28 commented Sep 16, 2024

Right now, the Linux CI builder uses JPackage to build for each platform, but the package is reset every time. JPackage supports building into an intermediary app-image (not an AppImage) and building the individual installers on top of that. Using this instead of rebuilding that will save a lot of CI minutes, and may be necessary once we also have Flatpaks and AppImages.

I've been thinking of doing this for a bit, and @\TheTollingBell raised the idea of putting it in an issue. I'll try and get this done after we merge these two PRs, as that'll be less likely to break anything.

@Jabster28
Copy link
Contributor Author

Should've mentioned: blocked by #1222, #1223, and #1250

@woodser woodser added the a:CI About Continuous Integration label Oct 2, 2024
@woodser woodser changed the title Build app as a JPackage app-image before making other installers Build app as a JPackage app-image before making other installers [0.5 XMR] Oct 7, 2024
@woodser woodser added the 💰bounty There is a bounty on this issue label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

There is a bounty on this issue. The amount is in the title. The reward will be awarded to the first person or group of people whose solution is accepted and merged.

In some cases, we may assign the issue to specific contributors. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progress. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of our bounty system.

@woodser
Copy link
Contributor

woodser commented Oct 7, 2024

I've added a bounty of 0.5 XMR to this issue.

@TheTollingBell (from your comment).

@TheTollingBell
Copy link
Contributor

I'm on it. Should be done by end of tomorrow EST time.

@TheTollingBell
Copy link
Contributor

Sorry, forgot that #1230 was blocking. I'll wait till all blocking PRs are merged before starting.

@woodser
Copy link
Contributor

woodser commented Oct 8, 2024

@TheTollingBell the changes from #1230 have been merged to master, so we're ready to build to the intermediary JPackage app image.

@woodser
Copy link
Contributor

woodser commented Oct 10, 2024

@Jabster28 has expressed interest in working on this too, in which case we're happy to take the first acceptable solution, in the interest of time for the next release.

@TheTollingBell
Copy link
Contributor

Almost done with my changes. I forgot to check on this issue lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:CI About Continuous Integration 💰bounty There is a bounty on this issue
Projects
None yet
Development

No branches or pull requests

3 participants