From 068edba0c61a7787d4e5e7e1c8b11687eab5e415 Mon Sep 17 00:00:00 2001 From: kmetin Date: Fri, 3 Nov 2023 09:42:58 +0300 Subject: [PATCH 1/5] add migration prerequisites --- base/commands/migration/migration_start.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/base/commands/migration/migration_start.go b/base/commands/migration/migration_start.go index 84368199..fff02fe6 100644 --- a/base/commands/migration/migration_start.go +++ b/base/commands/migration/migration_start.go @@ -39,7 +39,16 @@ func (StartCmd) Exec(ctx context.Context, ec plug.ExecContext) (err error) { ec.PrintlnUnnecessary(`Hazelcast Data Migration Tool v5.3.0 (c) 2023 Hazelcast, Inc. -Selected data structures in the source cluster will be migrated to the target cluster. +Selected data structures in the source cluster will be migrated to the target cluster. + +Prerequisites: + + * Only a single migration can be run simultaneously. + * The target cluster must be an enterprise cluster or Viridian cluster. + * At least one data structure must be given in the migration configuration. + * The data structures given in the migration configuration must exist in the source cluster. + * Existing data structures on the target cluster will be skipped. + * It is recommended source cluster to be in read-only mode. `) if !ec.Props().GetBool(clc.FlagAutoYes) { p := prompt.New(ec.Stdin(), ec.Stdout()) From a6f79c6e8040828588645e20c6c183bc4f4fdd6d Mon Sep 17 00:00:00 2001 From: kmetin Date: Fri, 3 Nov 2023 13:58:49 +0300 Subject: [PATCH 2/5] align with doc --- base/commands/migration/migration_start.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/base/commands/migration/migration_start.go b/base/commands/migration/migration_start.go index fff02fe6..f6caabec 100644 --- a/base/commands/migration/migration_start.go +++ b/base/commands/migration/migration_start.go @@ -46,9 +46,9 @@ Prerequisites: * Only a single migration can be run simultaneously. * The target cluster must be an enterprise cluster or Viridian cluster. * At least one data structure must be given in the migration configuration. - * The data structures given in the migration configuration must exist in the source cluster. - * Existing data structures on the target cluster will be skipped. - * It is recommended source cluster to be in read-only mode. + * The data structures given in the migration configuration must exist in the source cluster. + * Existing data structures on the target cluster will be skipped. + * It is recommended that the source cluster is put in read-only mode before the migration starts. `) if !ec.Props().GetBool(clc.FlagAutoYes) { p := prompt.New(ec.Stdin(), ec.Stdout()) From d835735c5261f0411ffbcc68228e57c253c05ed9 Mon Sep 17 00:00:00 2001 From: kmetin Date: Sat, 4 Nov 2023 20:16:05 +0300 Subject: [PATCH 3/5] fix PR comments --- base/commands/migration/migration_start.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/base/commands/migration/migration_start.go b/base/commands/migration/migration_start.go index f6caabec..a314ee22 100644 --- a/base/commands/migration/migration_start.go +++ b/base/commands/migration/migration_start.go @@ -45,9 +45,12 @@ Prerequisites: * Only a single migration can be run simultaneously. * The target cluster must be an enterprise cluster or Viridian cluster. - * At least one data structure must be given in the migration configuration. - * The data structures given in the migration configuration must exist in the source cluster. - * Existing data structures on the target cluster will be skipped. + * At least one data structure name must be provided in the migration configuration file. + * The data structures given in the migration configuration must exist in the source cluster. + +Further Information: + + * Existing data structures on the target cluster will be skipped. * It is recommended that the source cluster is put in read-only mode before the migration starts. `) if !ec.Props().GetBool(clc.FlagAutoYes) { From c46afd04d4fdb700c9001bdb020d215c94232183 Mon Sep 17 00:00:00 2001 From: kmetin Date: Mon, 6 Nov 2023 14:28:00 +0300 Subject: [PATCH 4/5] add Viridian item --- base/commands/migration/migration_start.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/base/commands/migration/migration_start.go b/base/commands/migration/migration_start.go index a314ee22..8eeab23c 100644 --- a/base/commands/migration/migration_start.go +++ b/base/commands/migration/migration_start.go @@ -49,9 +49,11 @@ Prerequisites: * The data structures given in the migration configuration must exist in the source cluster. Further Information: - + * Existing data structures on the target cluster will be skipped. * It is recommended that the source cluster is put in read-only mode before the migration starts. + * Viridian clusters supports at most 14GB of primal data. If you try to migrate more than that, the failure + is expected. You can consider Viridian Dedicated for larger data migrations."; `) if !ec.Props().GetBool(clc.FlagAutoYes) { p := prompt.New(ec.Stdin(), ec.Stdout()) From 481f2717e44636f1a4ae010f03fcdf55e444cf17 Mon Sep 17 00:00:00 2001 From: kmetin Date: Mon, 6 Nov 2023 14:28:29 +0300 Subject: [PATCH 5/5] remove typo --- base/commands/migration/migration_start.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/commands/migration/migration_start.go b/base/commands/migration/migration_start.go index 8eeab23c..65c9eace 100644 --- a/base/commands/migration/migration_start.go +++ b/base/commands/migration/migration_start.go @@ -53,7 +53,7 @@ Further Information: * Existing data structures on the target cluster will be skipped. * It is recommended that the source cluster is put in read-only mode before the migration starts. * Viridian clusters supports at most 14GB of primal data. If you try to migrate more than that, the failure - is expected. You can consider Viridian Dedicated for larger data migrations."; + is expected. You can consider Viridian Dedicated for larger data migrations. `) if !ec.Props().GetBool(clc.FlagAutoYes) { p := prompt.New(ec.Stdin(), ec.Stdout())