-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auto_connect for android #1644
base: develop
Are you sure you want to change the base?
Conversation
Can you describe the intended use for this feature? Typically, with Bleak, we always scan and then connect. |
There are restriction on scanning in android. It works each time when device is awake. When screen is off it fails in active and passive mode. Without this connect fails randomly when screen is off. |
I'm not sure I fully understand. You are saying that the restriction is with scanning, but the change is in |
I'm sorry form mixing this up. Those are two separate things.
|
This is how all other OSes work, so it sounds like we want |
It seems that both are needed depending on remote device configuration https://stackoverflow.com/questions/40156699/which-correct-flag-of-autoconnect-in-connectgatt-of-ble. If remote device do not advertise it would never be available I guess. Doc says.
My understanding is that true waits for advertisement from remote. false try to immediately connect to device which was "bonded" already. I can be wrong though. |
Pull Request Guidelines for Bleak
Before you submit a pull request, check that it meets these guidelines:
CHANGELOG.rst
, describing your changes as is specified by theguidelines in that document.
different problems and you are committing them in the same PR. In that case,
consider making several PRs instead.
AUTHORS.rst
file!