From 45a37e22b1e0ff597888434f73e76076478748f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Borr=C3=A1s?= Date: Fri, 6 Mar 2020 15:52:28 +0100 Subject: [PATCH] Check Headers before use in error responses --- src/TwitterAds/Errors/RateLimit.php | 4 ++-- src/TwitterAds/Errors/ServiceUnavailable.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/TwitterAds/Errors/RateLimit.php b/src/TwitterAds/Errors/RateLimit.php index f7fe740..85349aa 100644 --- a/src/TwitterAds/Errors/RateLimit.php +++ b/src/TwitterAds/Errors/RateLimit.php @@ -31,8 +31,8 @@ class RateLimit extends TwitterAdsException public function __construct($message, $code, Exception $previous = null, $errors, $headers) { parent::__construct($message, $code, null, $errors); - $this->retryAfter = $headers['x_rate_limit_limit']; - $this->resetAt = $headers['x_rate_limit_reset']; + $this->retryAfter = $headers['x_rate_limit_limit'] ? $headers['x_rate_limit_limit'] : ''; + $this->resetAt = $headers['x_rate_limit_reset'] ? $headers['x_rate_limit_reset'] : ''; } /** diff --git a/src/TwitterAds/Errors/ServiceUnavailable.php b/src/TwitterAds/Errors/ServiceUnavailable.php index 504bfb9..97aa11e 100644 --- a/src/TwitterAds/Errors/ServiceUnavailable.php +++ b/src/TwitterAds/Errors/ServiceUnavailable.php @@ -27,7 +27,7 @@ class ServiceUnavailable extends TwitterAdsException public function __construct($message, $code, Exception $previous = null, $errors, $headers) { parent::__construct($message, $code, null, $errors); - $this->retryAfter = $headers['retry-after']; + $this->retryAfter = isset($headers['retry-after']) ? $headers['retry-after'] : ''; } /**