Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALMA-FIx: Add publication-Element #1374

Closed
TobiasNx opened this issue Aug 10, 2022 · 4 comments
Closed

ALMA-FIx: Add publication-Element #1374

TobiasNx opened this issue Aug 10, 2022 · 4 comments
Assignees
Milestone

Comments

@TobiasNx
Copy link
Contributor

  <entity name="publication[]" flushWith="record">
    <entity name="" flushWith="260[ 23] |264[ 23][ 1]" reset="true" sameEntity="true">
      <data source="260[ 23] .c|264[ 23][ 1].c" name="publicationHistory" />
      <data source="260[ 23] .c|264[ 23][ 1].c" name="startDate">
        <replace pattern="[\[|\]|ca. |c ]" with=""/>
        <regexp match="^(\d{4}).*" format="${1}"/>
      </data>
      <data source="260[ 23] .c|264[ 23][ 1].c" name="endDate">
        <regexp match=".*-(\d{4})$" format="${1}"/>
      </data>
      <entity name="type[]" reset="true" sameEntity="true">
        <data name="" source="260[ 23] .c|264[ 23][ 1].c">
          <constant value="PublicationEvent"/>
        </data>
      </entity>
      <call-macro name="regex-del-punctuation-end" dsource="260[ 23] .a|264[ 23][ 1].a" dname="location" />
      <concat delimiter=". " name="publishedBy" flushWith="260[ 23] |264[ 23][ 1]" reset="true" sameEntity="true">
        <data source="260[ 23] .b|264[ 23][ 1].b">
          <replace pattern="^[©]|\s?[,.:;/=]?$" with="" />
        </data>
      </concat>
    </entity>
  </entity>

the corresponding fix transformation in titleRelatedFields is missing.
Have a look at the schema specifics since there need to be set some arrays. #1340

@TobiasNx
Copy link
Contributor Author

Publication is added, but the regexp for the cleaning must be fixed.

TobiasNx added a commit that referenced this issue Aug 12, 2022
TobiasNx added a commit that referenced this issue Aug 15, 2022
@TobiasNx TobiasNx added the ALMA label Aug 15, 2022
TobiasNx added a commit that referenced this issue Aug 15, 2022
TobiasNx added a commit that referenced this issue Aug 15, 2022
TobiasNx added a commit that referenced this issue Aug 17, 2022
dr0i pushed a commit that referenced this issue Aug 18, 2022
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Oct 4, 2022

@TobiasNx is this done?

@dr0i
Copy link
Member

dr0i commented Oct 4, 2022

We need an index to test this.

@dr0i
Copy link
Member

dr0i commented Oct 11, 2022

http://test.lobid.org/resources/search?q=HT012721542&format=json reveals the same data as in the test data , so I think this is done.
Closing.

@dr0i dr0i closed this as completed Oct 11, 2022
@TobiasNx TobiasNx added this to the ALMA-FIX milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants