Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache lookup table #1868

Closed
dr0i opened this issue Aug 18, 2023 · 2 comments
Closed

Cache lookup table #1868

dr0i opened this issue Aug 18, 2023 · 2 comments
Labels

Comments

@dr0i
Copy link
Member

dr0i commented Aug 18, 2023

Results from #1862:
We should not lookup isil2opac_hbzid.json but put it into the filesystem and make it hot-loadable (automatically reload this conf if it changes). We should then crontab (or webhook) to update isil2opac_hbzid.json.

Details:
web/conf/resources.conf:isil2opac_hbzid = "https://raw.githubusercontent.com/hbz/link-templates/master/isil2opac_hbzid.json"

Note: this is used in other projects , e.g. nwbib. Grep githubusercontent. Should be treated accordingly.

@TobiasNx
Copy link
Contributor

@dr0i I am not sure if we need to do this, since we are enriching the source data with this information, see: #1888

@dr0i
Copy link
Member Author

dr0i commented Sep 28, 2023

Ah , good to hear! The old lookup of websites every time was really not good.
Closing.

@dr0i dr0i closed this as completed Sep 28, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in lobid-resources Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants