Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed! #1

Open
hdahme opened this issue Mar 23, 2014 · 1 comment
Open

Completed! #1

hdahme opened this issue Mar 23, 2014 · 1 comment

Comments

@hdahme
Copy link
Owner

hdahme commented Mar 23, 2014

Hey @nesquena !

The base requirements (plus an optional one) are done, I'll hack away more on it in time to try and get the 'share' functionality working.

@nesquena
Copy link

👍 nice work Harrison. A few notes after checking out the code:

  • Properly reused the single method to fetch results for both initial load and the pagination
  • Your pagination is incorrect because "start" param is an offset rather than page i.e 0, 8, 16
  • Properly used spinners (with populated values) to allow users to select filters
  • Properly send and receive relevant filters using a bundle to pass data between activities
  • Good to see you used a filters object to represent the filters to apply to the query
  • As you mentioned, consider adding the ability to share an image. This is an important learning for this assignment even though it's optional.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants