-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"object_type" column in ExternalResources may not be sufficient #71
Comments
I believe the initial idea was to search for more specific structures such as Subject and that the user would want to see a variety of options to narrow down a search for whatever they were looking for. If we want to query something more specific then I think that should come from the feedback of the community. I am not sure of the kind of queries they would want. Query by name? (Assuming they know what they are looking for by name). |
Correct. The issue with tables is that the columns are typically just generic VectorData so that will typically be too generic for query. |
@oruebel @rly This has been quiet for a bit and that's my fault. Let's restart the conversation with a question: How would a user search for something they want? In the case above, the "object_type" column is generic. If they want to look for a specific column the only thing they could get would be all objects that are VectorData. Even so, what are they trying to look for? Are they searching by name of the column? Are they searching for all columns that have a certain value? I think it might be best to think of the "object_type" column as high level, i.e. finding Subjects, or specific TimeSeries subclasses, etc. Instead of changing the structure (because it's already a lot to look at for user) let's maybe shift to adding more query abilities. Thoughts? |
I think it may be worth separating the issue of search from the main HERD data structure. Common field for search would probably be Option 1: Since HERD is being serialized to Option 2: An alternative approach could also be to store a separate JSON file in HERD (which would have the same length as the These are just some ideas. We should discuss this issue a bit more. At first glance, I think Option 2 would be most flexible and may also be easiest to implement, but may not be optimal in terms of search performance (but probably still reasonable given the expected size). |
We added "object_type" in the objects table in ExternalResources to make queries easier.
But in DynamicTables, the "object_type" would be "VectorData" which is very generic and using that would pick up a lot of false positives, so it does not make queries for annotations of table columns any easier.
The text was updated successfully, but these errors were encountered: