Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot write added attributes to dataset in new data type subtype #1213

Open
rly opened this issue Nov 15, 2024 · 0 comments
Open

[Bug]: Cannot write added attributes to dataset in new data type subtype #1213

rly opened this issue Nov 15, 2024 · 0 comments
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Milestone

Comments

@rly
Copy link
Contributor

rly commented Nov 15, 2024

What happened?

See NeurodataWithoutBorders/pynwb#1992 for an example.

At this point in HDMF's ObjectMapper hdmf-dev/hdmf@26d584c/src/hdmf/build/objectmapper.py#L1107, the spec does not contain the new attributes, so new attributes are not written. The spec object has the updated "doc" for "data" from the SpatialSeries type (as opposed to the "doc" for "data" from the TimeSeries type) but it does not contain the new "bounds" attribute introduced in SpatialSeries.

The issue appears to be due to resolution of the spec as it is being read.

Steps to Reproduce

See https://github.com/NeurodataWithoutBorders/pynwb/issues/1992 for an example.

Traceback

No response

Operating System

macOS

Python Executable

Conda

Python Version

3.12

Package Versions

No response

@rly rly added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Nov 15, 2024
@rly rly added this to the Future milestone Nov 15, 2024
@rly rly changed the title [Bug]: Data type subtypes [Bug]: Cannot write added attributes to dataset in new data type subtype Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

No branches or pull requests

1 participant