Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit this page" links 404 #58

Open
illume opened this issue Jan 20, 2025 · 4 comments
Open

"Edit this page" links 404 #58

illume opened this issue Jan 20, 2025 · 4 comments
Labels
kind/bug Something isn't working

Comments

@illume
Copy link
Contributor

illume commented Jan 20, 2025

This page: https://headlamp.dev/docs/latest/development/plugins
Has this "edit this page" link: https://github.com/headlamp-k8s/headlamp-website/edit/main/docs/latest/development/plugins/index.md

The "edit this page" link should be: https://github.com/headlamp-k8s/headlamp/edit/main/docs/development/plugins/index.md

@illume illume added the kind/bug Something isn't working label Jan 20, 2025
@harsv689
Copy link

harsv689 commented Feb 4, 2025

Hey can it be assigned to me ?
/assign

@harsv689
Copy link

harsv689 commented Feb 5, 2025

Hey while working on the issue I got to know that the issue is much bigger !

As none of the Edit this page link is working because There's no documentation folder inside the headlamp website , instead using the script links-docs.sh, we first clone the docs folder from the headlamp repo to the headlamp-website repo , upto depth 1 as the ./docs/latest directory and then the docusaurus creates the static pages with their respective edit urls.

@harsv689
Copy link

harsv689 commented Feb 5, 2025

I will change the docusaurus config file to correctly point to the directory inside the headlamp repository of the same documentation file rather than pointing to the headlamp-website repository

@harsv689
Copy link

harsv689 commented Feb 5, 2025

#61 -- Incorporates all the changes required for the Edit this page on the headlamp-website and has passed all the checks. Waiting for merger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants