Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts or icons shouldn't be loaded from remote servers. #2820

Open
root-io opened this issue Jan 31, 2025 · 2 comments
Open

Fonts or icons shouldn't be loaded from remote servers. #2820

root-io opened this issue Jan 31, 2025 · 2 comments
Labels
bug Something isn't working frontend Issues related to the frontend

Comments

@root-io
Copy link

root-io commented Jan 31, 2025

Describe the bug

Fonts or icons shouldn't be loaded from remote servers.

api.iconify.design
api.simplesvg.com
api.unisvg.com

To Reproduce

Steps to reproduce the bug:

  1. Load cluster.

Environment (please provide info about your environment):

Headlamp Version: 0.28.0

Are you able to fix this issue?

No

@root-io root-io added the bug Something isn't working label Jan 31, 2025
@root-io root-io changed the title . Fonts or icons shouldn't be loaded from remote servers. Jan 31, 2025
@dosubot dosubot bot added the frontend Issues related to the frontend label Jan 31, 2025
@SumangalChhetri
Copy link

I see that fonts/icons are loaded from remote servers (e.g., api.iconify.design) which poses security and performance risks. I'm planning to bundle these assets locally (e.g., in a public/assets folder) and update the code accordingly. Please let me know if my understanding is off or if there are any additional considerations.

@joaquimrocha
Copy link
Collaborator

We already cache the icons:


Maybe some of them are not cached and we should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Issues related to the frontend
Projects
Development

No branches or pull requests

3 participants