frontend: refactor row action menus #2621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farodin91
force-pushed
the
cleanup-actions
branch
from
42947e0 to
8b1cc78
Compare
dosubot
bot
added
the
size:L
joaquimrocha
reviewed
Dec 6, 2024
| @@ -27,6 +27,7 @@ const checkExports = [ | |||
| 'ResourceListView', | |||
| 'ResourceTable', | |||
| 'resourceTableSlice', | |||
| 'ResourceTableSingleActions', | |||
There was a problem hiding this comment.
I wonder if this should actually be exported.
Signed-off-by: farodin91 <[email protected]>
farodin91
force-pushed
the
cleanup-actions
branch
from
8b1cc78 to
884b4b7
Compare
joaquimrocha
requested changes
Dec 10, 2024
Comment on lines
-87
to
+83
| actions?: null | RowAction[]; | ||
| actions?: null | HeaderAction[]; |
There was a problem hiding this comment.
I think we need to leave this with the previous type because plugins may be using it and it would mean a type break for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: Merge Row actions menus and details view header actions