Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Plug-In: Also detect victoriametrics #37

Open
micw opened this issue Apr 20, 2024 · 3 comments
Open

Prometheus Plug-In: Also detect victoriametrics #37

micw opened this issue Apr 20, 2024 · 3 comments

Comments

@micw
Copy link

micw commented Apr 20, 2024

Hello,

I run victoriametrics in my stacks (as replacement of prometheus). It should provide the same information (at least with lens it does) but it's not detected by the plug-in.

Could detection of victoriametrics be added? What is the exact mechanism to check if prometheus is available in the cluster or not?

@joaquimrocha
Copy link
Contributor

@yolossn Can you check this one?

@yolossn
Copy link
Contributor

yolossn commented Jul 16, 2024

The plugin searches the cluster for pods with the app.kubernetes.io/name=prometheus label to identify the prometheus pod to query the metrics. can you check if your prometheus pod has this label?

kubectl get pods -l app.kubernetes.io/name=prometheus --all-namespace

We are working on making the prometheus url configurable so that the user can configure the prometheus endpoint to fetch the metrics from.

@avanier
Copy link

avanier commented Sep 7, 2024

Just chiming in to say I've had a look into this, and it's not possible to overwrite that annotation if you're deploying VictoriaMetrics through the the VM operator, which is currently the recommended way to deploy VictoriaMetrics.

One option would be of extending this code to support the relevant VictoriaMetrics targets such as vmsingle and vmselect. Short-term this would work, but being able to set the query URL explicitly seems saner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants